Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Removing references to spk #27

Merged
merged 3 commits into from
Apr 25, 2020
Merged

Removing references to spk #27

merged 3 commits into from
Apr 25, 2020

Conversation

andrebriggs
Copy link
Member

@andrebriggs andrebriggs commented Apr 25, 2020 •
edited
Loading

Removed references to spk in most places and replaced with permutations of bedrock and bedrock cli where applicable.

Closes microsoft/bedrock#1354
Closes microsoft/bedrock#1361
Related to microsoft/bedrock#1384

  • Code coverage will gone down and we might need to override this PR. The reason for this is that I marked some tests as skip in as covered here: Some CLI infra generate unit tests are not unit tests bedrock#1385
    • Once this bug is resolved we should go back up
  • Right before merged of the PR we will need to update variables in the build for Bedrock CLI and the Bedrock CLI Integration tests in AzDO

jmspring
jmspring reviewed Apr 25, 2020
View reviewed changes
Copy link
Contributor

@jmspring jmspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@andrebriggs
Copy link
Member Author

As expected the build failed due to code coverage. I will override, re-run, and set back once we merge the PR

@andrebriggs andrebriggs marked this pull request as ready for review April 25, 2020 22:08
jmspring
jmspring approved these changes Apr 25, 2020
View reviewed changes
Copy link
Contributor

@jmspring jmspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrebriggs andrebriggs merged commit 8a62d82 into master Apr 25, 2020
@andrebriggs andrebriggs deleted the abrig_rename branch May 9, 2020 01:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evanlouie evanlouie evanlouie approved these changes

@jmspring jmspring jmspring approved these changes

@samiyaakhtar samiyaakhtar Awaiting requested review from samiyaakhtar

@dennisseah dennisseah Awaiting requested review from dennisseah

@yradsmikham yradsmikham Awaiting requested review from yradsmikham

@mtarng mtarng Awaiting requested review from mtarng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating spk.log to bedrock.log for cli tool Rename CLI
3 participants
@andrebriggs @jmspring @evanlouie