Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: Fix package test #514

Merged
6 commits merged into from
Jan 6, 2021
Merged

rust: Fix package test #514

6 commits merged into from
Jan 6, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 6, 2021

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • [] Ready to merge

Summary

Rust package tests were failing due to a missing BR and a bad test- this PR fixes both.

Change Log
Does this affect the toolchain?

NO

Test Methodology
  • Local build with RUN_CHECK=y

@ghost ghost added the Packaging label Jan 6, 2021
@ghost ghost requested a review from anphel31 January 6, 2021 01:30
@ghost ghost added the ptest package testing (%check section in spec) label Jan 6, 2021
@ghost ghost force-pushed the thcrain/rust-test-fix branch from 11f4777 to c3caefc Compare January 6, 2021 17:15
@ghost ghost changed the title rust: add test requirements rust: Fix package test Jan 6, 2021
@ghost
Copy link
Author

ghost commented Jan 6, 2021

Opting to ignore remainder of linter suggestions.

@ghost ghost marked this pull request as ready for review January 6, 2021 19:07
SPECS/rust/rust.spec Outdated Show resolved Hide resolved
@ghost ghost merged commit a0d8662 into 1.0-dev Jan 6, 2021
@ghost ghost deleted the thcrain/rust-test-fix branch January 6, 2021 19:20
henryli001 pushed a commit that referenced this pull request Jun 15, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Packaging ptest package testing (%check section in spec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants