Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] WALinuxAgent add python3-distro as Requires #2013

Merged

Conversation

hbeberman
Copy link
Member

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

WALinuxAgent depends on python3-distro but wasn't explicitly requesting it in the package. This was causing the agent to crash repeatedly on startup. After installing python3-distro the agent starts successfully.

Change Log
  • Add Requires python3-distro to WALinuxAgent
Does this affect the toolchain?

NO

Test Methodology
  • Local package build. Confirmed new RPM now has the dependency.
  • Manually installed python3-distro on the system exhibiting the failure

@hbeberman hbeberman requested review from jslobodzian and a team January 26, 2022 02:39
@ghost ghost added the Packaging label Jan 26, 2022
@hbeberman hbeberman merged commit 0457aa6 into microsoft:main Jan 26, 2022
@hbeberman hbeberman deleted the walinuxagent-requires-python3-distro branch January 26, 2022 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants