Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in my last PR #26053

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Fix a bug in my last PR #26053

merged 5 commits into from
Nov 13, 2024

Conversation

zijchen
Copy link
Member

@zijchen zijchen commented Nov 13, 2024

I originally had this line in there, but I changed it to the one in #26049 thinking it's more readable, but they're not the same as now this becomes undefined in the callback. Apparently in JS, passing function directly as argument binds it to a specific object instance, but using "lambda" functions doesn't. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11808342124

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 41.715%

Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/sql-database-projects/src/controllers/projectController.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/book/bookTreeView.ts 1 36.91%
Totals Coverage Status
Change from base Build 11807843306: -0.003%
Covered Lines: 30722
Relevant Lines: 68916

💛 - Coveralls

@zijchen zijchen merged commit 80a9af4 into main Nov 13, 2024
12 checks passed
@zijchen zijchen deleted the zijchen/november-1 branch November 13, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants