Added Telemetry and fixed Template Upload error #25991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11504358086Details
💛 - Coveralls |
| @@ -263,6 +263,7 @@ export const IMPORT_PERFORMANCE_DATA_DIALOG_OPEN_FOLDER = localize('sql.migratio | |||
| export const UPLOAD_TEMPLATE_TO_AZURE = localize('sql.migration.target.provisioning.upload.to.azure', "Deploy to Azure"); | |||
| export const SAVE_TO_DEVICE = localize('sql.migration.target.provisioning.generate.template', "Save to device"); | |||
| export const COPY_TO_CLIPBOARD = localize('sql.migration.target.provisioning.copy.to.clipboard', "Copy to clipboard"); | |||
| export const ARM_TEMPLATE_GENERATE_FAILED = localize('sql.migration.target.provisioning.copy.to.clipboard', "Failed to generate ARM template"); | |||
There was a problem hiding this comment.
Change it to appropriate helper string
...nsions/sql-migration/src/dialog/skuRecommendationResults/GenerateProvisioningScriptDialog.ts
Outdated
Show resolved
Hide resolved
yes working on mac,windows,linux. |
Bhavikshah123
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 3 things.
Added Telemetry for Target provisioning.
Instead of pasing skurecommendation file path , now we are passing just target type to the getarmtemplate API in toolsservice.
There was an intermitent issue while uploading ARM templates , the upload was failing sometimes. To fix this we are now generating Account SAS , earlier we were generating container SAS. This was problem with azure/storage-blob node module.
Found similar isue here - https://learn.microsoft.com/en-us/answers/questions/334786/azure-blob-storage-fails-to-authenticate-make-sure