Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use updated markdown renderer from vscode #16988

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Use updated markdown renderer from vscode #16988

merged 1 commit into from
Sep 3, 2021

Conversation

chlafreniere
Copy link
Contributor

Fixes #16333.

  • Ports marked.js fix (issue, PR). VS Code was leveraging marked.js 2.0.0, and this was fixed in 2.0.4.
  • Fixes tests that we created during this process
  • Leverages new renderer by default (setting can allow customers to go back to old renderer bits in a pinch)

@chlafreniere chlafreniere requested a review from a team September 3, 2021 04:56
Charles-Gagnon
Charles-Gagnon approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy regex batman 😲

@Charles-Gagnon
Copy link
Contributor

Also - consider bringing this to VS Code as well.

@chlafreniere chlafreniere merged commit d32f254 into main Sep 3, 2021
@chlafreniere chlafreniere deleted the chlafren/usevscodemarked branch September 3, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charles-Gagnon Charles-Gagnon Charles-Gagnon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate MarkedJS 2.0 Issues for TSGs
2 participants
@chlafreniere @Charles-Gagnon