Skip to content

Commit

Permalink
Commenting out listener threshold to fix extensions having mem leaks …
Browse files Browse the repository at this point in the history
…registering more listeners. (#24012) (#24024)

* Commenting out listener threshold

* Adding SQL carbon edit
  • Loading branch information
aasimkhan30 authored Jul 31, 2023
1 parent a840969 commit 8166c8e
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/vs/base/common/event.ts
Original file line number Diff line number Diff line change
Expand Up @@ -947,10 +947,11 @@ export class Emitter<T> {
this._listeners = new LinkedList();
}

if (this._leakageMon && this._listeners.size > this._leakageMon.threshold * 3) {
console.warn(`[${this._leakageMon.name}] REFUSES to accept new listeners because it exceeded its threshold by far`);
return Disposable.None;
}
// {{SQL CARBON EDIT}} Disabling threshold to unblock model view components to register more listeners. Due to the threshold, the components were not able to register listeners and were not able to handle click events.
// if (this._leakageMon && this._listeners.size > this._leakageMon.threshold * 3) {
// console.warn(`[${this._leakageMon.name}] REFUSES to accept new listeners because it exceeded its threshold by far`);
// return Disposable.None;
// }

const firstListener = this._listeners.isEmpty();

Expand Down

0 comments on commit 8166c8e

Please sign in to comment.