Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firewall feature #119

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Firewall feature #119

merged 2 commits into from
Feb 9, 2023

Conversation

rishky-msft
Copy link
Contributor

No description provided.

package.json Outdated
@@ -411,7 +411,7 @@
"devDependencies": {
"@types/node": "^13.11.0",
"@types/vscode": "^1.39.0",
"@types/azdata": "^1.40.0",
"@types/azdata": "1.41.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we keep it (^1.41.0)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

nitishsharma25
nitishsharma25 previously approved these changes Feb 8, 2023
@rishky-msft rishky-msft merged commit d9bcf53 into main Feb 9, 2023
@rishky-msft rishky-msft deleted the rishabhkumar/firewall-feature branch February 9, 2023 08:56
rishky-msft added a commit that referenced this pull request Feb 10, 2023
nitishsharma25 pushed a commit that referenced this pull request Feb 15, 2023
rishky-msft added a commit that referenced this pull request Feb 24, 2023
rishky-msft added a commit that referenced this pull request Feb 24, 2023
* Revert "Revert "Firewall feature (#119)" (#126)"

This reverts commit c8747de.

* Shortening path length for install directory

* Localizing firewall ui elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants