Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with auth #3431

Merged
merged 3 commits into from
Aug 19, 2019
Merged

Fix issues with auth #3431

merged 3 commits into from
Aug 19, 2019

Conversation

Flanker32
Copy link
Member

  • Close tool window listener when close project
  • Don't throw warning again when login with account with no subscription

@Flanker32 Flanker32 requested a review from andxu August 19, 2019 07:45
@Flanker32 Flanker32 merged commit b5a059e into microsoft:develop Aug 19, 2019
@Flanker32 Flanker32 deleted the hanxiao/auth branch August 19, 2019 08:21
This was referenced Aug 28, 2019
Closed
Closed
Closed
Closed
Closed
Closed
andxu pushed a commit to andxu/azure-tools-for-java that referenced this pull request Mar 24, 2020
@Flanker32
Fix issues with auth (microsoft#3431)
b9ed21e 
* Close tool window listener when close project

* Don't throw warning again when login with account with no subscription

* Fix logic error and compare string with utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andxu andxu andxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Flanker32 @andxu