Add refresh button for storage container in job upload storage panel #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezhang
reviewed
Oct 23, 2018
| } | ||
| }) | ||
| // refresh containers after refresh button is clicked | ||
| view.storagePanel.azureBlobCard.storageContainerComboBox.button.addActionListener { _ -> |
There was a problem hiding this comment.
Can _ -> be removed? #Resolved
| @@ -203,6 +201,7 @@ abstract class SparkSubmissionJobUploadStorageCtrl(val view: SparkSubmissionJobU | |||
| errorMsg = "Can't get storage containers, check if the key matches" | |||
| } | |||
| } | |||
| refreshContainersEnabled = true | |||
There was a problem hiding this comment.
The enable operation needs to be put into .doOnEach #Resolved
| private val storageAccountTip = "The default storage account of the HDInsight cluster, which can be found from HDInsight cluster properties of Azure portal." | ||
| private val storageKeyTip = "The storage key of the default storage account, which can be found from HDInsight cluster storage accounts of Azure portal." | ||
| private val storageAccountLabel = JLabel("Storage Account").apply { toolTipText = storageAccountTip } | ||
| val storageAccountField = JTextField().apply { toolTipText = storageAccountTip } | ||
| private val storageKeyLabel = JLabel("Storage Key").apply { toolTipText = storageKeyTip } | ||
| val storageKeyField = JTextArea().apply { toolTipText = storageKeyTip } | ||
| private val storageContainerLabel = JLabel("Storage Container") | ||
| val storageContainerComboBox = ComboBox<String>() | ||
| val storageContainerComboBox = ComboboxWithBrowseButton().apply { |
There was a problem hiding this comment.
May we can remove the type ComboBox from the value storageContainerComboBox, just name it storageContainerUI may be enough. #Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #2151