Added logic to handle HTTP-errors during file downloading #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of issue:
Customers reported that sometimes
NodeTool
task silently passes without completing of downloadingnode.js
. It happens due to the fact that there is no logic to handlehttp
related errorsDescription of fix:
I have added logic to handle
http
errors in functiondownloadTool
How changes were tested:
Looks like
nodejs.org
is throttling some customers and aborting their requests. I simulated such situation via toolTCPView
on windows anddsniff
on Ubuntu. I limited my network connection by npm-package@sitespeed.io/throttle
to get more time to interact with TCP connectionsScreenshots:
Before
After