Added logic to handle HTTP-errors during file downloading #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
vmapetr
approved these changes
Feb 27, 2023
kirill-ivlev
approved these changes
Feb 28, 2023
DmitriiBobreshev
approved these changes
Feb 28, 2023
wojgasior
approved these changes
Mar 1, 2023
KonstantinTyukalov
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
LGTM, Thanks!
Could you bump tool lib package version and update changelog?
merlynomsft
reviewed
Mar 1, 2023
merlynomsft
reviewed
Mar 1, 2023
|
@kirill-ivlev , @merlynomsft , @sergey-koryshev we had another sev2 escalation due to this just now. Please let's have a fix in master ASAP. Even if we need to split it in some way (a low-risk portion that addresses the problem + another portion which addresses the problem better) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of issue:
Customers reported that sometimes
NodeTooltask silently passes without completing of downloadingnode.js. It happens due to the fact that there is no logic to handlehttprelated errorsDescription of fix:
I have added logic to handle
httperrors in functiondownloadToolHow changes were tested:
Looks like
nodejs.orgis throttling some customers and aborting their requests. I simulated such situation via toolTCPViewon windows anddsniffon Ubuntu. I limited my network connection by npm-package@sitespeed.io/throttleto get more time to interact with TCP connectionsScreenshots:
Before
After