Add extra options to dotnet pack command #9956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Add Include Symbols parameter to pack command -Add Include Source parameter to pack command Build and tests passing.
|
@alexmullans can you have someone in your team look at this |
|
@ryandle and I chatted on this offline. I'm happy to accept the Include Symbols and Include Sources parameters, but I'd like to avoid re-adding the Additional Arguments parameter. We'll be providing a better all-up story here late in Q2 or early in Q3 that allows you to specify whatever arguments you want, without causing hard-to-debug conflicts when Additional Arguments conflict with arugments provided by the task. @ryandle, can you revise the PR to remove the Additional Arguments field? |
|
Yes, working on a revision. |
# Conflicts: # Tasks/DotNetCoreCLIV2/task.loc.json
|
@alexmullans this PR is ready for a review from your team. |
infin8x
reviewed
Apr 19, 2019
zjrunner
approved these changes
Apr 19, 2019
zjrunner
reviewed
Apr 19, 2019
zjrunner
suggested changes
Apr 19, 2019
Tasks/DotNetCoreCLIV2/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
change capitalization of NuGet Co-Authored-By: ryandle <[email protected]>
…-pipelines-tasks into packCommandUpdates # Conflicts: # Tasks/DotNetCoreCLIV2/task.json
zjrunner
reviewed
Apr 20, 2019
-fix the other NuGet capitalization in readme.md
zjrunner
approved these changes
Apr 20, 2019
|
Thanks for the contribution and the extra back and forth at the end! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9924
-Add Include Symbols parameter
-Add Include Source parameter
Build and tests passing.