Added Kubectl tool installer task #9945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anumita
requested review from
shashankbarsin,
ajinkya599,
vithati and
bansalaseem
vithati
approved these changes
Mar 27, 2019
bansalaseem
reviewed
Apr 1, 2019
| throw new Error(tl.loc("NotAValidSemverVersion")); | ||
| } | ||
|
|
||
| return "v"+version; |
There was a problem hiding this comment.
should not we check whether it starts with v or not and based on that either add it or not.
There was a problem hiding this comment.
the above line "toollib.cleanVersion" removes the v prefix
| import kubectlutility = require("utility-common/kubectlutility"); | ||
|
|
||
| export async function getKuberctlVersion(): Promise<string> { | ||
| let kubectlVersion = tl.getInput("kubectlVersion"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Download and cache specific versions of kubectl.