Add image utils to gather metadata #9915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabasnidhi
reviewed
Mar 25, 2019
| namespace = namespace ? namespace + '/' : ''; | ||
|
|
||
| return "https://" + registry + namespace + repository + "@sha256:" + digest; |
There was a problem hiding this comment.
If namespace is non-empty, while repository is empty string, In that case return value would be ".....namespace/@sha256....". Having "/@" in continuation does not seem correct
bansalaseem
approved these changes
Mar 25, 2019
|
|
||
| export function getResourceName(image: string, digest: string) { | ||
| var match = image.match(/^(?:([^\/]+)\/)?(?:([^\/]+)\/)?([^@:\/]+)(?:[@:](.+))?$/); |
There was a problem hiding this comment.
can u please add a comment around this regex?
dabasnidhi
reviewed
Mar 25, 2019
| var namespace = match[2]; | ||
| var repository = match[3]; | ||
| var tag = match[4]; |
There was a problem hiding this comment.
We are not using tags in resource url. Do we need this here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.