Users/eyma/appcenter distribute fix aliases #9902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octopotato
commented
Mar 21, 2019
octopotato
commented
- Remove conflicting aliases from both distributionGroupIds and distributionStoreId that were causing issues with yaml build configuration
- Bump patch version of AppCenterDistributeV3
added 2 commits
March 21, 2019 10:44
…utionStoreId to not be conflicting We were using the same aliases for both distributionGroupId and distributionStoreId which caused a bug in the yaml configurations since it wasn't clear which field a value should resolve to.
damccorm
approved these changes
Mar 21, 2019
There was a problem hiding this comment.
Thanks for the quick turnaround, LGTM. @stephenmichaelf FYI
octopotato
pushed a commit
that referenced
this pull request
Mar 21, 2019
Cherry pick #9902 to release/m148
octopotato
pushed a commit
that referenced
this pull request
Mar 21, 2019
Cherry pick #9902 to release/m149
octopotato
pushed a commit
that referenced
this pull request
Mar 22, 2019
…-m148 [AppCenter/Distribute] Cherrypick #9902 to release/m148
octopotato
pushed a commit
that referenced
this pull request
Mar 22, 2019
…-m149 [AppCenter/Distribute] Cherrypick #9902 to release/m149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.