Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure App Service - windows container deployment support #9858

Merged
merged 11 commits into from
Mar 20, 2019
Merged

Azure App Service - windows container deployment support #9858

merged 11 commits into from
Mar 20, 2019

Conversation

vincent1173
Copy link
Contributor

@vincent1173 vincent1173 commented Mar 18, 2019 •
edited
Loading

image

  • L0 test failure fix

supports #9548

@vincent1173 vincent1173 added Area: Release Area: AzureAppService Label to monitor Azure App Service issues labels Mar 18, 2019
@SumiranAgg
Copy link
Contributor

Why have we upgraded patch for function app and web app tasks? As per my understanding only container tasks will be affected.

@SumiranAgg
Copy link
Contributor

Datasource has to be fixed to list both linux and windows type apps on container.

@SumiranAgg
Copy link
Contributor

Will we be adding this support in old task?

@vincent1173
Copy link
Contributor Author

Why have we upgraded patch for function app and web app tasks? As per my understanding only container tasks will be affected.

there is a new CI check that expects task version for changed common modules are updated.

@vincent1173
Copy link
Contributor Author

Will we be adding this support in old task?

no :)

@vincent1173
Copy link
Contributor Author

Datasource has to be fixed to list both linux and windows type apps on container.

sure. working on that.

@SumiranAgg SumiranAgg self-requested a review March 19, 2019 06:45
SumiranAgg
SumiranAgg reviewed Mar 20, 2019
View reviewed changes
Tasks/AzureFunctionAppContainerV1/azurefunctiononcontainerprovider.ts
@@ -29,9 +30,16 @@ export class AzureFunctionOnContainerDeploymentProvider{
this.azureEndpoint = await new AzureRMEndpoint(this.taskParams.connectedServiceName).getEndpoint();
console.log(tl.loc('GotconnectiondetailsforazureRMWebApp0', this.taskParams.WebAppName));

if(!this.taskParams.ResourceGroupName){
var appDetails = await AzureResourceFilterUtility.getAppDetails(this.azureEndpoint, this.taskParams.WebAppName);
if(!this.taskParams.ResourceGroupName) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move this code to taskparameters? For multi-container, we might do some checks on apptype before deployment provider is invoked.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed that logic, as function app container has only linux

@vincent1173 vincent1173 merged commit b22f64b into master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SumiranAgg SumiranAgg SumiranAgg approved these changes

@kmkumaran kmkumaran Awaiting requested review from kmkumaran

Assignees
No one assigned
Labels
Area: AzureAppService Label to monitor Azure App Service issues Area: Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent1173 @SumiranAgg