Add "silently continue" to mysql command location #9848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andor-pierdelacabeza <[email protected]>
andor-pierdelacabeza
requested review from
kmkumaran and
RoshanKumarMicrosoft
as code owners
RoshanKumarMicrosoft
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like that "Get-Command" line function is checking if 'mysql' command is already available, and, in that case, exit the script with a '0' exit code, and if that's not the case, then keep installing the client.
Thing is, if mysql is not available, it will throw a CommandNotFoundException and break the script.
So, to allow the script keep going, I've added the
-ErrorAction SilentlyContinueparameter to Get-Command.Signed-off-by: andor-pierdelacabeza [email protected]