Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special case ia32 #9716

Merged
merged 4 commits into from
Sep 19, 2019
Merged

Special case ia32 #9716

merged 4 commits into from
Sep 19, 2019

Conversation

damccorm
Copy link

@damccorm damccorm commented Mar 1, 2019

Node uses x86 for these downloads.

Fixes #9132 and #9656

@damccorm damccorm requested a review from hross as a code owner March 1, 2019 20:20
@damccorm damccorm mentioned this pull request Apr 12, 2019
Merged
@damccorm damccorm requested a review from jtpetty September 19, 2019 14:01
jtpetty
jtpetty approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@jtpetty jtpetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtpetty jtpetty merged commit 2aca1eb into master Sep 19, 2019
@damccorm damccorm deleted the users/damccorm/issue-9132 branch January 10, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmichaelf stephenmichaelf stephenmichaelf left review comments

@jtpetty jtpetty jtpetty approved these changes

@chunfantasy chunfantasy chunfantasy approved these changes

@bryanmacfarlane bryanmacfarlane Awaiting requested review from bryanmacfarlane

@hross hross Awaiting requested review from hross

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Node version task fails on x86 agent in x64 machine
4 participants
@damccorm @stephenmichaelf @chunfantasy @jtpetty