Setting up Azure Active cloud corresponding to service endpoint #9003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachinma
approved these changes
Dec 5, 2018
Tasks/AzureCLIV1/azureclitask.ts
Outdated
| @@ -178,6 +179,15 @@ export class azureclitask { | |||
| } | |||
| } | |||
|
|
|||
| private static async setAzureCloudBasedOnServiceEndpoint(): Promise<void> { | |||
| var connectedService: string = tl.getInput("connectedServiceNameARM", true); | |||
| const endpoint: AzureEndpoint = await new AzureRMEndpoint(connectedService).getEndpoint(); | |||
There was a problem hiding this comment.
You can also do "tl.getEndpointDataParameter(connectedService, 'environment', true)" instead of taking dependency on azure-arm-rest
bishal-pdMSFT
approved these changes
Dec 5, 2018
vineetmimrot
added a commit
that referenced
this pull request
Dec 5, 2018
* Setting up Azure Active cloud corresponding to service endpoint * Fix review comment
vineetmimrot
added a commit
that referenced
this pull request
Dec 5, 2018
… (#9006) * Setting up Azure Active cloud corresponding to service endpoint * Fix review comment
vineetmimrot
added a commit
that referenced
this pull request
Dec 12, 2018
* Revert "Setting up Azure Active cloud corresponding to service endpoint (#9003) (#9006)" This reverts commit 8ebe8db. * Revert "Add Global Azure CLI config flag (#8996) (#8998)" This reverts commit be92e08. * Revert "Azure cli path undefined fix. (#8954)" This reverts commit 2a04bae. * Revert "Set local confg dir for az cli so that multiple tasks can run in parallel (#8656)" This reverts commit f29fe65. * increase version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.