Made command dropdown optional in Kubernetes V0 and V1 task #8931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bansalaseem
reviewed
Nov 29, 2018
| @@ -229,6 +229,7 @@ tr.registerMock('./utilities', { | |||
| StringWritable: ut.StringWritable, | |||
| PackerVersion: ut.PackerVersion, | |||
| isGreaterVersion: ut.isGreaterVersion, | |||
| setOutputVariable: ut.setOutputVariable, | |||
There was a problem hiding this comment.
why setoutputVariable?
bansalaseem
reviewed
Nov 29, 2018
| @@ -70,7 +70,9 @@ function createConfigMap(connection: ClusterConnection, configMapName: string): | |||
| command.arg("configmap"); | |||
| command.arg(configMapName); | |||
| command.line(getConfigMapArguments()); | |||
| return connection.execCommand(command); | |||
| return connection.execCommand(command).fin(function cleanup() { | |||
There was a problem hiding this comment.
why function name is cleanup?
bansalaseem
reviewed
Nov 29, 2018
| @@ -67,7 +67,9 @@ function createDockerRegistrySecret(connection: ClusterConnection, authenticatio | |||
| command.arg("--docker-password="+ authenticationToken.getPassword()); | |||
| command.arg("--docker-email="+ authenticationToken.getEmail()); | |||
|
|
|||
| return connection.execCommand(command); | |||
| return connection.execCommand(command).fin(function cleanup() { | |||
There was a problem hiding this comment.
same as above, cleanup?
bansalaseem
reviewed
Nov 29, 2018
| @@ -92,7 +94,9 @@ function createGenericSecret(connection: ClusterConnection, secret: string): any | |||
| command.line(secretArguments); | |||
| } | |||
|
|
|||
| return connection.execCommand(command); | |||
| return connection.execCommand(command).fin(function cleanup() { | |||
bansalaseem
reviewed
Nov 29, 2018
Tasks/KubernetesV0/src/utilities.ts
Outdated
| export function setOutputVariable(value: string) { | ||
| var ouputVariableName = tl.getInput("kubectlOutput", false); | ||
| if(ouputVariableName) { | ||
| tl.setVariable(ouputVariableName, value); |
There was a problem hiding this comment.
can it cause a secret to get leaked?
bansalaseem
reviewed
Nov 30, 2018
| @@ -70,7 +71,9 @@ function createConfigMap(connection: ClusterConnection, configMapName: string): | |||
| command.arg("configmap"); | |||
| command.arg(configMapName); | |||
| command.line(getConfigMapArguments()); | |||
| return connection.execCommand(command); | |||
| return connection.execCommand(command).fin(function cleanup() { | |||
bansalaseem
reviewed
Nov 30, 2018
| @@ -63,7 +64,9 @@ function createDockerRegistrySecret(connection: ClusterConnection, authenticatio | |||
| command.arg("--docker-password="+ authenticationToken.getPassword()); | |||
| command.arg("--docker-email="+ authenticationToken.getEmail()); | |||
|
|
|||
| return connection.execCommand(command); | |||
| return connection.execCommand(command).fin(function cleanup() { | |||
Anumita
force-pushed
the
users/ansheno/kubeCmdDrpOptional
branch
from
410af18 to
54b5e3b
Compare
Anumita
force-pushed
the
users/ansheno/kubeCmdDrpOptional
branch
from
54b5e3b to
ccf9456
Compare
bansalaseem
approved these changes
Nov 30, 2018
Anumita
force-pushed
the
users/ansheno/kubeCmdDrpOptional
branch
from
08fde7c to
a161008
Compare
Anumita
force-pushed
the
users/ansheno/kubeCmdDrpOptional
branch
from
b5969c2 to
35884bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, output variables are populated only with the output of the kubectl command.
As the command dropdown will be optional now, the output variable if there is no command specified
will be populated with the name of the configmap or secret created.