Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative paths in PublishCodeCoverageResultsV1 #8913

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

joshmgross
Copy link
Member

Currently, relative paths do not work in PublishCodeCoverageResultsV1 due to the task skipping any file name matching when wildcards are not present. findMatch should be called regardless of if the path contains wildcards so that relative paths can still be found.

See: #8300

@joshmgross joshmgross requested a review from madhurig November 26, 2018 23:00
Copy link
Contributor

@madhurig madhurig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, please put notes on what you tested.

@joshmgross
Copy link
Member Author

Testing:

  • Tested updated task on local deployment using the tfs-cli tool and confirmed that the updated task works with relative paths as well as full paths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants