[New Task] Function App Deploy - Windows / Linux #8826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SumiranAgg
added
Area: Release
Area: AzureAppService
SumiranAgg
requested review from
kmkumaran,
vincent1173 and
RoshanKumarMicrosoft
vincent1173
changed the title
|
|
||
| The Azure Function Deployment task is used to update Azure App Service to deploy [Functions](https://docs.microsoft.com/en-us/azure/azure-functions/) to Azure. The task works on cross platform Azure Pipelines agents running Windows, Linux or Mac and uses the underlying deployment technologies of RunFromPackage, Zip Deploy and [Kudu REST APIs](https://github.com/projectkudu/kudu/wiki/REST-API). | ||
|
|
||
| The task works for [ASP.NET](https://www.visualstudio.com/en-us/docs/release/examples/azure/azure-web-apps-from-build-and-release-hubs), [ASP.NET Core](https://www.visualstudio.com/en-us/docs/release/examples/azure/aspnet-core10-azure-web-apps), PHP, Java, Python, Go and [Node.js](https://www.visualstudio.com/en-us/docs/release/examples/nodejs/node-to-azure-webapps) based web applications. |
There was a problem hiding this comment.
For each url it is redirecting to same landing page. Is this expected ?
There was a problem hiding this comment.
Yes. This is same as parent task. Will cross check if has to be replaced.
Tasks/AzureFunctionDeploymentV1/deploymentProvider/BuiltInLinuxWebAppDeploymentProvider.ts
Show resolved
Hide resolved
| "name": "AzureFunctionDeployment", | ||
| "friendlyName": "Azure Function", | ||
| "description": "Update Azure Function on Windows, Function on Linux with built-in images, ASP.NET, .NET Core, PHP, Python or Node.js based Web applications", | ||
| "helpMarkDown": "[More information](https://aka.ms/azurefunctiondeployreadme)", |
| "Patch": 0 | ||
| }, | ||
| "releaseNotes": "What's new in version 1.* (preview)<br />Supports Zip Deploy, Run From Package, War Deploy<br />Supports App Service Environments<br />Improved UI for discovering different App service types supported by the task<br/>Run From Package is the preferred deployment method, which makes files in wwwroot folder read-only<br/>Click [here](https://aka.ms/azurefunctiondeployreadme) for more information.", | ||
| "minimumAgentVersion": "2.104.1", |
There was a problem hiding this comment.
Is there any reason not supporting 1.x version of agent ?
Tasks/AzureFunctionDeploymentV1/deploymentProvider/WindowsWebAppZipDeployProvider.ts
Show resolved
Hide resolved
Tasks/AzureFunctionDeploymentV1/deploymentProvider/WindowsWebAppZipDeployProvider.ts
Show resolved
Hide resolved
Tasks/AzureFunctionDeploymentV1/deploymentProvider/WindowsWebAppRunFromZipProvider.ts
Show resolved
Hide resolved
| tl.debug("Compressed folder into zip " + archivedWebPackage); | ||
| this.zipDeploymentID = await this.kuduServiceUtility.deployUsingZipDeploy(archivedWebPackage); | ||
| break; | ||
| case PackageType.zip: |
There was a problem hiding this comment.
Please put Space between zip and break .
|
Please add link of java function app deployment through our task So it will be very helpful for user . |
|
Please add L0 for this. |
RoshanKumarMicrosoft
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.