Universal Package task should store version number in env variable #8731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mber, so save this information in an enviroment variable prior to completion
|
|
zjrunner
reviewed
Nov 15, 2018
zjrunner
reviewed
Nov 20, 2018
Tasks/UniversalPackagesV0/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
zjrunner
reviewed
Nov 20, 2018
Tasks/UniversalPackagesV0/task.json
Outdated
| "label": "Package Ouput Variable", | ||
| "required": false, | ||
| "defaultValue": "", | ||
| "groupName": "packagePublishDetails", |
There was a problem hiding this comment.
@mitchdenny - in the publish details group, not an output group like your other example?
There was a problem hiding this comment.
Updated to include an output group
zjrunner
reviewed
Nov 20, 2018
zjrunner
reviewed
Nov 20, 2018
|
@zjrunner this change looks good to me - did you want to merge it or shall I? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Universal Packages can be uploaded without a predetermined version number, so save this information in an environment variable prior to completion