Download artifacts from partially succeeded builds #8660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@omeshp, please review my PR. FYI, I'm willing to add tests if required but I would just need some directions since there are none on the DownloadBuildArtifactsV0 task for now. |
|
@GitHubSriramB, @kasubram, if any of you could review this PR as well, I would be great. Thanks. |
|
@kmkumaran, any news about this? |
Lovakumar
approved these changes
Nov 9, 2018
added 2 commits
November 9, 2018 20:26
…o allow to download artifacts from partially succeeded builds
Thilas
force-pushed
the
improve-download-artifact
branch
from
72a8881 to
5d340f7
Compare
omeshp
approved these changes
Nov 15, 2018
|
What's next? It has been approved so I guess it just need to be merged now, right? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #8431, add option to DownloadBuildArtifactsV0 task in order to allow to download artifacts from partially succeeded builds.