Download Helm from redirect url. #7805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bansalaseem
reviewed
Jul 26, 2018
| if (typeof options === 'string') { | ||
| options = redirectUrl; | ||
| } | ||
| else { |
There was a problem hiding this comment.
Refactor this to a separate method call getRedirectOptions
bansalaseem
reviewed
Jul 26, 2018
| import * as tl from "vsts-task-lib/task"; | ||
|
|
||
| export async function download(url: any, downloadPath: string, printData: boolean): Promise<void> { | ||
| export async function download(options: any, downloadPath: string, printData: boolean, isRedirectUrl: boolean = false): Promise<void> { |
There was a problem hiding this comment.
rename isRedirectUrl this to handleRedirect
bansalaseem
reviewed
Jul 26, 2018
| reject(new Error('Failed to download file status code: ' + res.statusCode)); | ||
| if(res.statusCode < 200 || res.statusCode >= 300) { | ||
| if((res.statusCode >= 300 || res.statusCode < 400) | ||
| && !isRedirectUrl |
There was a problem hiding this comment.
refactor this to isRedirect
bansalaseem
reviewed
Jul 26, 2018
| } | ||
|
|
||
| function getRedirectOptions(options: any, redirectUrl: string): any { | ||
| tl.debug("Download latest release from redirect uri: " + redirectUrl); |
There was a problem hiding this comment.
Change the debug log from Download latest release … to something more meaningful. This method should not know that it is being used in download function
bansalaseem
approved these changes
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.