Merge ServiceFabricDeploy task related changes #7751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommands (#7588) * Re-tries for copy and register commands * PR comments * PR comments and few suggestion as per Oana * connect, unregister, create, remove re-tries * L0 for unregister retry * L0 for create and remove application * Utilities changes which were not picked in merge * PR comments
#7593) * Moving retry logic for UpgradeApplication to corresponding helper function * Updated function name * Added new operation * Indentation * Adding timeout exception
* Retry for remaining commands * PR comment
* Adding logs for upgrade service fabric application. * resolving comments * Forming upgrade errors message. * Formatting unhealthy evaluation and upgrade status. * fixed merge changes * Formatting UnhealthyEvaluation and DomainUpgradeStatus while printing only conditionally. * Moved waiting for upgrade to complete and printing logic to function in Utilities file. * Keeping other exception as well.
* Implemented Async operations * Added null checks * Modified code as per review comments * typo * Revert "typo" This reverts commit f04d14e. * Revert "Modified code as per review comments" This reverts commit e24bc53. * Modified code as per review comments * Modified code as per review comments * Addressed review comments * Added retry logic to Wait-ServiceFabricApplicationTypeRegistrationStatus * Added comments * Addressed review comments * typo * Added comments * typo * Addressed review comments * Updated test cases * Modified code as per review comments
* Corrected typo. * Corrected retry message null check
* Added powershell helper module * Replacing Trace-VstsEnteringInvocation with print statement * Removing Trace-VstsLeavingInvocation $MyInvocation * Addressed review comments
| { | ||
| return $true | ||
| } | ||
| # if app type exist and if its status has changed to a terminal one, throw |
There was a problem hiding this comment.
I had this minor comment in previous PR: why is the elseif condition required. It should always throw if reached here
| return $true | ||
| } | ||
| # if app type exist and if its status has changed to a terminal one, throw | ||
| elseif(($appType.Status -ne [System.Fabric.Query.ApplicationTypeStatus]::Provisioning) -and ($appType.Status -ne [System.Fabric.Query.ApplicationTypeStatus]::Unprovisioning)) |
bishal-pdMSFT
approved these changes
Jul 17, 2018
hiyadav
approved these changes
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.