Unzip extract async bug #7724
Merged
Unzip extract async bug #7724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Java Tool Installer Task fails when the jdk is provided as a zip file. The issue is caused by the extractFiles method not awaiting the async result of the unzipExtract method. Instead the extractFiles method returns before the unzip powershell command has been executed causing the task to fail. Adressed the issue by chaining the async execution of the unzipExtract method through to the async run method of the task.
|
|
keljos
approved these changes
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java Tool Installer Task fails when the jdk is provided as a zip
file.
The issue is caused by the extractFiles method not awaiting the
async result of the unzipExtract method. Instead the extractFiles method
returns before the unzip powershell command has been executed causing the task to fail.
Adressed the issue by chaining the async execution of the unzipExtract
method through to the async run method of the task.
Issue:
#7725