Transforming git url to http url while downloading commits from Jenki… #7650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHubSriramB
approved these changes
Jul 7, 2018
| if (!!commitUrl) { | ||
| if (commitUrl.startsWith('git@')) { | ||
| tl.debug('repo url is a git protocol url'); | ||
|
|
|
|
||
| return JSON.stringify(commitMessages); | ||
|
|
||
| } catch(error) { |
|
|
||
|
|
||
| if (commitUrl.startsWith('[email protected]')) { | ||
| result= commitUrl.replace('[email protected]:', 'https://gitlab.com/').replace('.git/', '/'); |
There was a problem hiding this comment.
you mentioned user name related handling for GitLab. is this required?
There was a problem hiding this comment.
sorry, yes this is sufficient. This is how the url looks like [email protected]:username/project.git we should translate this to https://gitlab.com/username/project/commit/{commitId} same with github. GitHub url looks like [email protected]:kasubram/TestRepo.git we should translate this to kasubram/TestRepo@{commitId}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ns job.