-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure App Service V3 folder and make Azure PowerShell V3 GA #7633
Conversation
asranja
commented
Jul 5, 2018
- Added AzureRmWebAppDeploymentV3 - ported from releases/m131
- Removed preview from Azure PowerShell V3
As you get a chance, we are moving away from typings since it's deprecated and moving to @ types. |
@@ -16,14 +16,13 @@ | |||
"author": "Microsoft Corporation", | |||
"version": { | |||
"Major": 3, | |||
"Minor": 0, | |||
"Patch": 5 | |||
"Minor": 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any Build or Release templates that uses this task and now needs to point to latest version?
@@ -0,0 +1,147 @@ | |||
import tl = require('vsts-task-lib/task'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from copy of V3 task, can you call out the places where you have done changes so that it can work with latest common. It becomes easy to review the delta. Right now, because of copy, the diff is huge and the delta (if any) is not prominent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is literally no delta other than the task.json file. I copy pasted the AzureRmWebAppDeployment folder from releases/m131 branch to the current master.
Tasks/AzurePowerShellV3/task.json
Outdated
"Minor": 0, | ||
"Patch": 5 | ||
"Minor": 1, | ||
"Patch": 0 | ||
}, | ||
"releaseNotes": "This is an early preview. Added support for Fail on standard error and ErrorActionPreference", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change the releaseNotes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RoopeshNair to provide Release Notes
Tasks/AzurePowerShellV3/task.json
Outdated
"Minor": 0, | ||
"Patch": 5 | ||
"Minor": 1, | ||
"Patch": 0 | ||
}, | ||
"releaseNotes": "This is an early preview. Added support for Fail on standard error and ErrorActionPreference", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RoopeshNair to provide Release Notes