Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure App Service V3 folder and make Azure PowerShell V3 GA #7633

Merged
merged 2 commits into from
Jul 13, 2018

Conversation

asranja
Copy link
Contributor

@asranja asranja commented Jul 5, 2018

  1. Added AzureRmWebAppDeploymentV3 - ported from releases/m131
  2. Removed preview from Azure PowerShell V3

@asranja asranja requested review from vincent1173 and kmkumaran July 5, 2018 10:56
@stephenmichaelf
Copy link
Member

As you get a chance, we are moving away from typings since it's deprecated and moving to @ types.

@kmkumaran kmkumaran self-assigned this Jul 5, 2018
@@ -16,14 +16,13 @@
"author": "Microsoft Corporation",
"version": {
"Major": 3,
"Minor": 0,
"Patch": 5
"Minor": 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any Build or Release templates that uses this task and now needs to point to latest version?

@@ -0,0 +1,147 @@
import tl = require('vsts-task-lib/task');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from copy of V3 task, can you call out the places where you have done changes so that it can work with latest common. It becomes easy to review the delta. Right now, because of copy, the diff is huge and the delta (if any) is not prominent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is literally no delta other than the task.json file. I copy pasted the AzureRmWebAppDeployment folder from releases/m131 branch to the current master.

"Minor": 0,
"Patch": 5
"Minor": 1,
"Patch": 0
},
"releaseNotes": "This is an early preview. Added support for Fail on standard error and ErrorActionPreference",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the releaseNotes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RoopeshNair to provide Release Notes

"Minor": 0,
"Patch": 5
"Minor": 1,
"Patch": 0
},
"releaseNotes": "This is an early preview. Added support for Fail on standard error and ErrorActionPreference",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RoopeshNair to provide Release Notes

@asranja asranja merged commit 2fc1f4c into master Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants