Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Powershell on target machine version V1 and window machine file copy … #7500

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Powershell on target machine version V1 and window machine file copy … #7500

merged 1 commit into from
Jun 20, 2018

Conversation

RoshanKumarMicrosoft
Copy link
Contributor

…V1 in master

@RoshanKumarMicrosoft
Copy link
Contributor Author

Bringing this PR changes in master

@chshrikh
Copy link
Contributor

looks fine, post merge test the packing once

@kmkumaran
Copy link
Member

Was there any bug fix done to initial telemetry change as part of #6941. There was once an issue debugged by @arjgupta.

@kmkumaran
Copy link
Member

@rokmicrosoft - Can you check the CDP has test coverage for both these tasks specifically for the 1.x version.

@kmkumaran kmkumaran self-assigned this Jun 19, 2018
@RoshanKumarMicrosoft
Copy link
Contributor Author

RoshanKumarMicrosoft commented Jun 20, 2018 •
edited
Loading

We have test coverage in CDP for WindowsFileCopy and powershellontargetmachine also for version 1.x

@RoshanKumarMicrosoft RoshanKumarMicrosoft merged commit 5639c85 into master Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmkumaran kmkumaran kmkumaran approved these changes

@chshrikh chshrikh Awaiting requested review from chshrikh

Assignees

@kmkumaran kmkumaran

Labels
Area: Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RoshanKumarMicrosoft @chshrikh @kmkumaran