Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize app insights web test name in Azure App Service Manage Task #7477

Merged
merged 4 commits into from
Jul 20, 2018

Conversation

hkamel
Copy link
Contributor

@hkamel hkamel commented Jun 14, 2018

Parameterize app insights web test name in Azure App Service Manage Task by providing the user with a configurable test name input. If not provided the default test name will be used.

New Parameter name: Application Insights Web test name

screen shot 2018-06-15 at 12 50 53 am

Copy link

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@kmkumaran kmkumaran requested review from Ajay-MS and vincent1173 June 15, 2018 05:25
@kmkumaran kmkumaran self-assigned this Jun 15, 2018
@vincent1173 vincent1173 added the Area: AzureAppService Label to monitor Azure App Service issues label Jun 22, 2018
@@ -187,6 +187,15 @@
},
"visibleRule": "Action == Enable Continuous Monitoring",
"helpMarkDown": "Select Application Insights resource where continuous monitoring data will be recorded. <br/>If your application insights resource is not listed here and you want to create a new resource, click on [+New] button. Once the resource is created on Azure Portal, come back here and click on refresh button."
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this input under 'Advanced settings'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hkamel can you give me collaborator permission so that I can update the required changes to your PR.

@Ajay-MS Ajay-MS merged commit 6ae79b6 into microsoft:master Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: AzureAppService Label to monitor Azure App Service issues Area: Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants