Clean up Copy Files over SSH #7464
Conversation
| // This method will find the list of matching files for the specified contents | ||
| // This logic is the same as the one used by CopyFiles task except for allowing dot folders to be copied | ||
| // This will be useful to put in the task-lib | ||
| function getFilesToCopy(sourceFolder, contents: string[]): string[] { |
There was a problem hiding this comment.
This logic was moved to the vsts-task-lib. Since you are updating, it is a good idea to delete all this and simply use the lib methods the way CopyFiles does now: https://github.com/Microsoft/vsts-tasks/blob/master/Tasks/CopyFilesV2/copyfiles.ts#L20
There was a problem hiding this comment.
It looks like the two work a little differently right now, so this will be a behavior change: https://buildcanary.visualstudio.com/CanaryBuilds/CanaryBuilds%20Team/_build/results?buildId=71763&view=logs
There was a problem hiding this comment.
ok lets leave that change for a major update then!
|
I can update the task.json. I had originally done this change at the same time as the bug fix which is why I didn't bump the version. |
Doing this separate from #7459 to keep the change smaller
var->constorletTesting
https://buildcanary.visualstudio.com/CanaryBuilds/_apps/hub/ms.vss-ciworkflow.build-ci-hub?_a=edit-build-definition&id=457