Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change in post deployment execution #7438

Merged
merged 4 commits into from
Jun 20, 2018
Merged

change in post deployment execution #7438

merged 4 commits into from
Jun 20, 2018

Conversation

SumiranAgg
Copy link
Contributor

No description provided.

@SumiranAgg SumiranAgg requested a review from vincent1173 June 12, 2018 11:13
@kmkumaran kmkumaran self-assigned this Jun 13, 2018
@SumiranAgg SumiranAgg added the Area: AzureAppService Label to monitor Azure App Service issues label Jun 13, 2018
@SumiranAgg SumiranAgg requested a review from kmkumaran June 18, 2018 07:53
vincent1173
vincent1173 reviewed Jun 20, 2018
View reviewed changes
Tasks/AzureRmWebAppDeploymentV4/postDeploymentScript/mainCmdFile.sh
sh "$HOME/site/VSTS_PostDeployment_$1/kuduPostDeploymentScript.sh" 2> "$HOME/site/VSTS_PostDeployment_$1/stderr.txt" 1> "$HOME/site/VSTS_PostDeployment_$1/stdout.txt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is $HOME getting replaced by /home properly here?
Can you please run the task with Ruby Template once?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$Home is getting resolved correctly. Validated by running the template.

Tasks/AzureRmWebAppDeploymentV4/postDeploymentScript/deleteLogFile.cmd
@@ -1,21 +1,21 @@
@echo off

DEL "mainCmdFile_%1.cmd"
DEL "mainCmdFile.cmd"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we need to pass the absolute file path here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not required as we are running delete_log_file script from the folder in which mainCmdFile resides

@SumiranAgg SumiranAgg merged commit fe563fa into master Jun 20, 2018
@SumiranAgg SumiranAgg deleted the users/suaggar/postdeployment branch June 20, 2018 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincent1173 vincent1173 vincent1173 approved these changes

@kmkumaran kmkumaran Awaiting requested review from kmkumaran

Assignees

@kmkumaran kmkumaran

Labels
Area: AzureAppService Label to monitor Azure App Service issues Area: Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SumiranAgg @vincent1173 @kmkumaran @suaggar