[DotnetCoreInstaller] Fetching download urls from releases.json file #7434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesattiraju
changed the title
sachinma
requested changes
Jun 20, 2018
| @@ -36,7 +39,7 @@ | |||
| "label": "Version", | |||
| "defaultValue": "1.0.4", | |||
| "required": true, | |||
| "helpMarkDown": "Specify exact version of .NET Core SDK or runtime to install.<br/><br/>Examples:<br/>1. To install 1.0.4 SDK, use 1.0.4<br/>2. To install 1.1.2 runtime, use 1.1.2<br/>2. To install 2.0 preview 2 runtime, use 2.0.0-preview2-25407-01<br/><br/>For getting more details about exact version, refer [here](https://github.com/dotnet/core/blob/master/release-notes/releases.csv)" | |||
| "helpMarkDown": "Specify exact version of .NET Core SDK or runtime to install.<br/><br/>Examples:<br/>1. To install 1.0.4 SDK, use 1.0.4<br/>2. To install 1.1.2 runtime, use 1.1.2<br/>2. To install 2.0 preview 2 runtime, use 2.0.0-preview2-25407-01<br/><br/>For getting more details about exact version of runtime (, refer [here](https://github.com/dotnet/core/blob/master/release-notes/releases.json)" | |||
There was a problem hiding this comment.
This is not precise. Fix this and work with atul if required.
|
|
||
| export class DotNetCoreReleaseFetcher { | ||
|
|
||
| public static async getDownloadUrls(osSuffixes: string[], version: string, type: string) { |
| public static async getDownloadUrls(osSuffixes: string[], version: string, type: string) { | ||
| let downloadUrls = []; | ||
| let releasesCSV = await this.getReleasesJson(); | ||
| let versionsInfo = JSON.parse(await releasesCSV.readBody()); |
|
|
||
| export class DotNetCoreReleaseFetcher { | ||
|
|
||
| public static async getDownloadUrls(osSuffixes: string[], version: string, type: string) { |
There was a problem hiding this comment.
add some comments explaining the parameters
| let release = releasesInfo[0]; | ||
| let blobUrl: string = release['blob-' + type]; | ||
| let dlcUrl: string = release['dlc-' + type]; | ||
| let fileName: string = release[type + '-' + osSuffixes[0]] ? release[type + '-' + osSuffixes[0]] : release[type + '-' + osSuffixes[1]]; |
There was a problem hiding this comment.
you can check that the osSuffixes has a length of 2.
| let output: string = result.stdout; | ||
|
|
||
| let index; | ||
| if (index = output.indexOf("Primary:")) { |
There was a problem hiding this comment.
This wont work since the index would be -1
| command = command.concat(" -SharedRuntime"); | ||
| try { | ||
| downloadPath = await toolLib.downloadTool(downloadUrls[i]); | ||
| downloaded = true; |
There was a problem hiding this comment.
break here itself instead of having an if condition at the top
sachinma
requested changes
Jun 22, 2018
| @@ -6,7 +6,7 @@ | |||
| "loc.input.label.packageType": "Package to install", | |||
| "loc.input.help.packageType": "Please select whether to install only runtime or full SDK.", | |||
| "loc.input.label.version": "Version", | |||
| "loc.input.help.version": "Specify exact version of .NET Core SDK or runtime to install.<br/><br/>Examples:<br/>1. To install 1.0.4 SDK, use 1.0.4<br/>2. To install 1.1.2 runtime, use 1.1.2<br/>2. To install 2.0 preview 2 runtime, use 2.0.0-preview2-25407-01<br/><br/>For getting more details about exact version of runtime (, refer [here](https://github.com/dotnet/core/blob/master/release-notes/releases.json)", | |||
| "loc.input.help.version": "Specify exact version of .NET Core SDK or runtime to install.<br/><br/>Examples:<br/>1. To install 1.0.4 SDK, use 1.0.4<br/>2. To install 1.1.2 runtime, use 1.1.2<br/>2. To install 2.0 preview 2 runtime, use 2.0.0-preview2-25407-01<br/><br/>For getting more details about exact version refer [here](https://github.com/dotnet/core/blob/master/release-notes/releases.json)", | |||
There was a problem hiding this comment.
The help text is not up-to the mark. Can you specify the exact strings to look for in the json
sachinma
approved these changes
Jun 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7417