Moved UseDiffPackage checkbox to Upgrade section and enabled it by default #7345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishal-pdMSFT
suggested changes
May 31, 2018
| @@ -95,9 +95,9 @@ | |||
| "name": "useDiffPackage", | |||
| "type": "boolean", | |||
| "label": "Use Diff Package", | |||
| "defaultValue": "false", | |||
| "defaultValue": "true", | |||
There was a problem hiding this comment.
you should also enable compression option by default
There was a problem hiding this comment.
Not required now as per requirements
| @@ -95,9 +95,9 @@ | |||
| "name": "useDiffPackage", | |||
| "type": "boolean", | |||
| "label": "Use Diff Package", | |||
| "defaultValue": "false", | |||
| "defaultValue": "true", | |||
There was a problem hiding this comment.
minor: move this code piece to all other inputs which are in upgrade group
| @@ -95,9 +95,9 @@ | |||
| "name": "useDiffPackage", | |||
There was a problem hiding this comment.
Can you please show me how the UI looks like?
bishal-pdMSFT
approved these changes
Jun 4, 2018
| @@ -16,8 +16,8 @@ | |||
| ], | |||
| "version": { | |||
| "Major": 1, | |||
| "Minor": 7, | |||
| "Patch": 9 | |||
| "Minor": 8, | |||
There was a problem hiding this comment.
Just update patch version. No need to update minor version.
kuvinodms
pushed a commit
that referenced
this pull request
Jun 6, 2018
…fault (#7345) * Moved UseDiffPackage checkbox to Upgrade section and enabled it by default * Keeping default value same * Moving input code location * Updating patch version
kuvinodms
pushed a commit
that referenced
this pull request
Jun 6, 2018
…ogic for skip upgrade (#7384) * Moved UseDiffPackage checkbox to Upgrade section and enabled it by default (#7345) * Moved UseDiffPackage checkbox to Upgrade section and enabled it by default * Keeping default value same * Moving input code location * Updating patch version * Moving up the logic for skip upgrade (#7373) * Moving up the logic to skip upgrade * Moving up the logic to check the existence of old application * Modified code as per review comments * Revert "Moved UseDiffPackage checkbox to Upgrade section and enabled it by default (#7345)" This reverts commit a1b9ff5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.