Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export dotnet root #7306

Merged
merged 3 commits into from
May 30, 2018
Merged

Export dotnet root #7306

merged 3 commits into from
May 30, 2018

Conversation

wli3
Copy link

@wli3 wli3 commented May 25, 2018

Fix #7255

Upload to my Account and tested

image

@wli3
Copy link
Author

wli3 commented May 25, 2018

@sachinma @bryanmacfarlane

@sachinma
Copy link
Member

@DS-MS, @bishal-pdMSFT can you review this?

Also @wli3 can you update the patch version of the task. Make sure to do the build using the documentation here: https://github.com/Microsoft/vsts-tasks/blob/master/docs/contribute.md#build-a-specific-task-recommended and update the generated files also.

@wli3
Copy link
Author

wli3 commented May 29, 2018

@sachinma @DS-MS, @bishal-pdMSFT I bumped the patch version. And I built and checked-in the build result from node make.js build --task DotNetCoreInstallerV0

@thesattiraju
Copy link
Contributor

@wli3 I'll do some testing, and close this PR tomorrow. Thank you for your contribution :)

@thesattiraju thesattiraju merged commit 9abc997 into microsoft:master May 30, 2018
@wli3 wli3 deleted the export-dotnet-root branch May 30, 2018 17:51
hililh pushed a commit that referenced this pull request May 31, 2018
* Export dotnet root

* Bump the patch version of DotNetCoreInstallerV0

* Checkin result of node make.js build --task DotNetCoreInstallerV0
hililh added a commit that referenced this pull request May 31, 2018
* Export dotnet root

* Bump the patch version of DotNetCoreInstallerV0

* Checkin result of node make.js build --task DotNetCoreInstallerV0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants