-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplification of Docker task #7282
Conversation
Hi @vithati, just some minor suggestions: 1. YAML names vs. UI labelsWhen this Docker task is used from YAML, it can be confusing when the YAML input names don't match the UI labels. Can you please consider changing the "name"s of these inputs to more closely match their UI labels, or adding aliases so that either name can be used?
2. Sentence casingThe input labels are mixed between sentence-casing and capitalizing all words. Consider sentence-casing all labels, so "Image Names Path" would be "Image names path" as recommended in the Cloud Style Guide (https://worldready.blob.core.windows.net/editorimages/1314657228.png). We just learned about this. 😲 3. Consider removing aliasesWith a new major version, you could change input "name" values to the input "alias" values so that the aliases can be deleted. This does have the downside that if people move from version 1 to 2 in the UI designer, their previous input value won't carry over to the newly-named input value. 😞 4. Docker brandThe messages at the bottom of task.json should capitalize "docker" as "Docker". 5. Dockerfiles
Thanks for considering these! |
Make the task command line friendly
Bump up version with breaking changes
Remove working directory from advanced section
Rename action to command and make the combobox editable
Remove additional image - For Build, Tag, Push image
Remove build arguments
Add Arguments
Run an image remains same (do not add arguments)
Push command: Add a checbox which is unchecked by default. Name it "Push multiple images". When checked hide "Image Name" and show " Image Name path"
Build command:-
Push command with multiple images:-
Push command:-
Run command:-
Tag command with multiple images:-
Tag command:-
User command:-