Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume ARM endpoint from Common for several tasks. #7281

Merged
merged 8 commits into from
Jun 5, 2018

Conversation

asranja
Copy link
Contributor

@asranja asranja commented May 24, 2018

No description provided.

@thesattiraju
Copy link
Contributor

You've added a check for this.endpoint.environment != null in the getEndpoint function, but it can be undefined too. You might want to fix that, to make the tests pass.


var credentials = new msRestAzure.ApplicationTokenCredentials(servicePrincipalId, tenantId, servicePrincipalKey, armUrl, envAuthorityUrl, activeDirectoryResourceId, isAzureStackEnvironment);
return credentials;
var azureEndpoint = await new AzureRMEndpoint(connectedService).getEndpoint();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run an auto-formatter to fix the indentation.

@asranja asranja merged commit 6e3fb3c into master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants