Deprecated XamarinComponentRestore #7266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keljos
approved these changes
May 22, 2018
madhurig
suggested changes
May 22, 2018
| "helpMarkDown": "[More Information](https://go.microsoft.com/fwlink/?LinkId=786653)", | ||
| "category": "Package", | ||
| "author": "Microsoft Corporation", | ||
| "version": { | ||
| "Major": 0, | ||
| "Minor": 131, | ||
| "Minor": 136, |
There was a problem hiding this comment.
You need to set deprecated to true in the JSON like here: https://github.com/Microsoft/vsts-tasks/blob/master/Tasks/XcodePackageiOSV0/task.json#L17
| @@ -2,17 +2,18 @@ | |||
| "id": "ff50fc97-da8c-4683-b014-34c15315ee5f", | |||
| "name": "XamarinComponentRestore", | |||
| "friendlyName": "Xamarin Component Restore", | |||
| "description": "Restores Xamarin components for the specified solution", | |||
| "description": "[Deprecated] Restores Xamarin components for the specified solution", | |||
There was a problem hiding this comment.
Shouldn't be needed to add the "deprecated" string in the description if you set the property
There was a problem hiding this comment.
Update the description on how to move forward, in this case we should recommend using NuGet task instead. See docs: https://github.com/Microsoft/vsts-tasks/blob/055ea3d834113b2b484879c62a01c1238625f002/docs/deprecatedtasks.md
madhurig
reviewed
May 22, 2018
madhurig
approved these changes
May 22, 2018
|
Were you saying yesterday that this was totally broken? |
added 2 commits
May 23, 2018 12:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.