Users/rok/mysql task api upgradation #7250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent1173
reviewed
May 19, 2018
| @@ -11,12 +11,20 @@ | |||
| "type": "node", | |||
| "dest": "./", | |||
| "compile": true | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
not sure about taking such dependency on webdeployment-common for a single function.
Can we move the function to vsts-task-lib and consume from there?
There was a problem hiding this comment.
@vincentdass Later we will move this in task-lib But this PR will go for hotfix so we want minimal changes.
There was a problem hiding this comment.
@rokmicrosoft , changes looks fine to me. please do a story to remove the dependency.
vincent1173
approved these changes
May 20, 2018
| @@ -11,12 +11,20 @@ | |||
| "type": "node", | |||
| "dest": "./", | |||
| "compile": true | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
@rokmicrosoft , changes looks fine to me. please do a story to remove the dependency.
kmkumaran
approved these changes
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.