fixed single file blob upload #7222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttps://github.com/Microsoft/vsts-tasks into Microsoft/users/raagra/afc-single-file-upload-fix
…ttps://github.com/Microsoft/vsts-tasks into Microsoft/users/raagra/afc-single-file-upload-fix
…ttps://github.com/Microsoft/vsts-tasks into Microsoft/users/raagra/afc-single-file-upload-fix
…ttps://github.com/Microsoft/vsts-tasks into Microsoft/users/raagra/afc-single-file-upload-fix
…ttps://github.com/Microsoft/vsts-tasks into Microsoft/users/raagra/afc-single-file-upload-fix
arjgupta
reviewed
May 17, 2018
Tasks/AzureFileCopyV2/Utility.ps1
Outdated
|
|
||
| $uploadToBlobCommand = "& `"$azCopyExeLocation`" /Source:$sourcePath /Dest:$containerURL /DestKey:`"$storageKey`" $additionalArguments" | ||
| $uploadToBlobCommand = "& `"$azCopyExeLocation`" /Source:$resolvedSourcePath /Dest:$containerURL /DestKey:`"$storageKey`" $additionalArguments" |
There was a problem hiding this comment.
log the upload to blob command
There was a problem hiding this comment.
already doing that above
arjgupta
reviewed
May 17, 2018
Tasks/AzureFileCopyV2/Utility.ps1
Outdated
| { | ||
| $fileInfo = Get-Item $sourcePath | ||
| $resolvedSourcePath = $fileInfo.Directory.FullName | ||
| $additionalArguments += " /Pattern:$($fileInfo.Name)" |
There was a problem hiding this comment.
fileinfo can have white spaces in name here. It should be enclosed in quotes
arjgupta
reviewed
May 17, 2018
Tasks/AzureFileCopyV2/Utility.ps1
Outdated
| @@ -275,16 +293,16 @@ function Upload-FilesToAzureContainer | |||
| } | |||
| finally | |||
| { | |||
| Handle-AzCopyLogs -isLogsPresent $useDefaultArguments -logsFilePath $azCopyLogFilePath -ErrorAction SilentlyContinue | |||
| Handle-AzCopyLogs -isLogsPresent $useDefaultArguments -logsFilePath "$azCopyLogFilePath" -ErrorAction SilentlyContinue | |||
There was a problem hiding this comment.
nit, you do not need to enclose it in double quotes.
arjgupta
reviewed
May 17, 2018
Tasks/AzureFileCopyV2/Utility.ps1
Outdated
| $blobPrefix = $blobPrefix.Trim() | ||
| $containerURL = [string]::Format("{0}/{1}/{2}", $blobStorageEndpoint.Trim("/"), $containerName, $blobPrefix).Trim("/") | ||
| $azCopyExeLocation = Join-Path -Path $azCopyLocation -ChildPath "AzCopy.exe" | ||
|
|
||
| Write-Verbose "Executing command: & `"$azCopyExeLocation`" /Source:$sourcePath /Dest:$containerURL /DestKey:`"*****`" $additionalArguments" | ||
| Write-Verbose "Executing command: & `"$azCopyExeLocation`" /Source:`"$resolvedSourcePath`" /Dest:`"$containerURL`" /DestKey:`"*****`" $additionalArguments" |
There was a problem hiding this comment.
I think it will be better if you write this with ##[command] and write it to output and not the verbose stream. Will be better experience. And no need to repeat the command here and in the next line. create it once, and then use it wherever. Later if this command changes, you will need to update at only place.
arjgupta
approved these changes
May 18, 2018
rajatagrawal-dev
added a commit
that referenced
this pull request
May 24, 2018
* fixed single file blob upload * fixed single file blob upload * fixed L0 * clean target issue + pr comments * pr feedback
rajatagrawal-dev
added a commit
that referenced
this pull request
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.