Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmdline bash and powershell scripts to show the environment variable block in the Task Editor #7121

Merged
merged 2 commits into from
May 2, 2018

Conversation

darthwillis
Copy link
Contributor

No description provided.

@darthwillis darthwillis requested a review from ericsciple May 2, 2018 17:36
@@ -67,7 +67,7 @@
"label": "Script",
"visibleRule": "targetType = inline",
"required": true,
"defaultValue": "# Write your commands here",
"defaultValue": "# Write your commands here\n\n# Use the environment variables input below to pass secret variables to this script.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The first sentence doesn't have a comment. The second sentence does. Consider making them consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

@ericsciple
Copy link
Contributor

looks good

@darthwillis darthwillis force-pushed the users/brwillis/showenvironmentblock branch from ce55749 to 813bbf7 Compare May 2, 2018 18:00
@darthwillis darthwillis merged commit 5fafbba into master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants