Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Go string tweaks based on team feedback #7115

Merged
merged 2 commits into from
May 9, 2018
Merged

Minor Go string tweaks based on team feedback #7115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e3634f
Go string tweaks based on team feedback
davidstaheli May 1, 2018
4ef12e2
Make minor version increase sequential (not sprint number)
davidstaheli May 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Tasks/Go/Strings/resources.resjson/en-US/resources.resjson
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
{
"loc.friendlyName": "Go",
"loc.helpMarkDown": "[More Information](https://go.microsoft.com/fwlink/?linkid=867582)",
"loc.description": "Get, build, test a go application, or run a custom go command.",
"loc.description": "Get, build, or test a Go application, or run a custom Go command.",
"loc.instanceNameFormat": "go $(command)",
"loc.group.displayName.advanced": "Advanced",
"loc.input.label.command": "Command",
"loc.input.help.command": "Select a Go command to run. Select 'Custom' to use a command not listed here.",
"loc.input.label.customCommand": "Custom command",
"loc.input.help.customCommand": "Custom Go command for execution. For example: to execute go version, enter version.",
"loc.input.help.customCommand": "A custom Go command to execute. For example, to execute 'go version', enter 'version'.",
"loc.input.label.arguments": "Arguments",
"loc.input.help.arguments": "Arguments to the selected command. For example, build time arguments for go build command.",
"loc.input.label.workingDirectory": "Working Directory",
"loc.input.help.workingDirectory": "Current working directory where the script is run. Empty is the root of the repo (build) or artifacts (release), which is $(System.DefaultWorkingDirectory)",
"loc.messages.TaskFailedWithError": "Go task failed with error: %s"
"loc.input.help.arguments": "Optional arguments to the selected command. For example, build-time arguments for the 'go build' command.",
"loc.input.label.workingDirectory": "Working directory",
"loc.input.help.workingDirectory": "The working directory where the command will run. When empty, the root of the repository (for builds) or artifacts (for releases) is used, which is the value of '$(System.DefaultWorkingDirectory)'.",
"loc.messages.TaskFailedWithError": "The Go task failed with an error: %s"
}
14 changes: 7 additions & 7 deletions Tasks/Go/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"id": "34B37FDD-BBF7-4EF1-B37C-9652CA7BB355",
"name": "Go",
"friendlyName": "Go",
"description": "Get, build, test a go application, or run a custom go command.",
"description": "Get, build, or test a Go application, or run a custom Go command.",
"helpMarkDown": "[More Information](https://go.microsoft.com/fwlink/?linkid=867582)",
"author": "Microsoft Corporation",
"preview": true,
Expand All @@ -13,7 +13,7 @@
],
"version": {
"Major": 0,
"Minor": 1,
"Minor": 2,
"Patch": 0
},
"runsOn": [
Expand Down Expand Up @@ -48,7 +48,7 @@
{
"name": "customCommand",
"label": "Custom command",
"helpMarkDown": "Custom Go command for execution. For example: to execute go version, enter version.",
"helpMarkDown": "A custom Go command to execute. For example, to execute 'go version', enter 'version'.",
"required": true,
"type": "string",
"visibleRule": "command == custom"
Expand All @@ -59,13 +59,13 @@
"label": "Arguments",
"defaultValue": "",
"required": false,
"helpMarkDown": "Arguments to the selected command. For example, build time arguments for go build command."
"helpMarkDown": "Optional arguments to the selected command. For example, build-time arguments for the 'go build' command."
},
{
"name": "workingDirectory",
"type": "filePath",
"label": "Working Directory",
"helpMarkDown": "Current working directory where the script is run. Empty is the root of the repo (build) or artifacts (release), which is $(System.DefaultWorkingDirectory)",
"label": "Working directory",
"helpMarkDown": "The working directory where the command will run. When empty, the root of the repository (for builds) or artifacts (for releases) is used, which is the value of '$(System.DefaultWorkingDirectory)'.",
"required": "false",
"groupName": "advanced"
}
Expand All @@ -78,6 +78,6 @@
}
},
"messages": {
"TaskFailedWithError" : "Go task failed with error: %s"
"TaskFailedWithError" : "The Go task failed with an error: %s"
}
}
2 changes: 1 addition & 1 deletion Tasks/Go/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
],
"version": {
"Major": 0,
"Minor": 1,
"Minor": 2,
"Patch": 0
},
"runsOn": [
Expand Down
12 changes: 6 additions & 6 deletions Tasks/GoTool/Strings/resources.resjson/en-US/resources.resjson
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
{
"loc.friendlyName": "Go Tool Installer",
"loc.helpMarkDown": "[More Information](https://go.microsoft.com/fwlink/?linkid=867581)",
"loc.description": "Finds or downloads specific version of Go tool into tools cache and adds it to the PATH. Use this task to change the version of Go Lang used in subsequent tasks",
"loc.description": "Finds or downloads a specific version of Go in the tools cache and adds it to the PATH. Use this to set the version of Go used in subsequent tasks.",
"loc.instanceNameFormat": "Use Go $(version)",
"loc.group.displayName.advanced": "Advanced",
"loc.input.label.version": "Version",
"loc.input.help.version": "Go tool version to download and install. Example: 1.9.3",
"loc.input.help.version": "The Go version to download (if necessary) and use. Example: 1.9.3",
"loc.input.label.goPath": "GOPATH",
"loc.input.help.goPath": "Value for the GOPATH environment variable.",
"loc.input.help.goPath": "A custom value for the GOPATH environment variable.",
"loc.input.label.goBin": "GOBIN",
"loc.input.help.goBin": "Value for the GOBIN environment variable.",
"loc.messages.FailedToDownload": "Failed to download version %s. Please verify that the version is valid and resolve any other issues. Error: %s",
"loc.messages.TempDirNotSet": "Expected Agent.TempDirectory to be set"
"loc.input.help.goBin": "A custom value for the GOBIN environment variable.",
"loc.messages.FailedToDownload": "Failed to download Go version %s. Verify that the version is valid and resolve any other issues. Error: %s",
"loc.messages.TempDirNotSet": "The 'Agent.TempDirectory' environment variable was expected to be set."
}
14 changes: 7 additions & 7 deletions Tasks/GoTool/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"id": "334727F4-9495-4F9D-A391-FC621D671474",
"name": "GoTool",
"friendlyName": "Go Tool Installer",
"description": "Finds or downloads specific version of Go tool into tools cache and adds it to the PATH. Use this task to change the version of Go Lang used in subsequent tasks",
"description": "Finds or downloads a specific version of Go in the tools cache and adds it to the PATH. Use this to set the version of Go used in subsequent tasks.",
"helpMarkDown": "[More Information](https://go.microsoft.com/fwlink/?linkid=867581)",
"category": "Tool",
"preview": "true",
Expand All @@ -13,7 +13,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 0,
"Minor": 1,
"Minor": 2,
"Patch": 0
},
"satisfies": ["GO"],
Expand All @@ -33,20 +33,20 @@
"label": "Version",
"defaultValue": "1.10",
"required": true,
"helpMarkDown": "Go tool version to download and install. Example: 1.9.3"
"helpMarkDown": "The Go version to download (if necessary) and use. Example: 1.9.3"
},
{
"name": "goPath",
"type": "string",
"label": "GOPATH",
"helpMarkDown": "Value for the GOPATH environment variable.",
"helpMarkDown": "A custom value for the GOPATH environment variable.",
"groupName": "advanced"
},
{
"name": "goBin",
"type": "string",
"label": "GOBIN",
"helpMarkDown": "Value for the GOBIN environment variable.",
"helpMarkDown": "A custom value for the GOBIN environment variable.",
"groupName": "advanced"
}
],
Expand All @@ -57,7 +57,7 @@
}
},
"messages": {
"FailedToDownload": "Failed to download version %s. Please verify that the version is valid and resolve any other issues. Error: %s",
"TempDirNotSet": "Expected Agent.TempDirectory to be set"
"FailedToDownload": "Failed to download Go version %s. Verify that the version is valid and resolve any other issues. Error: %s",
"TempDirNotSet": "The 'Agent.TempDirectory' environment variable was expected to be set."
}
}
2 changes: 1 addition & 1 deletion Tasks/GoTool/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 0,
"Minor": 1,
"Minor": 2,
"Patch": 0
},
"satisfies": [
Expand Down