Users/suaggar/dynamic extension list #7071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent1173
added
Area: Release
Area: AzureAppService
vincent1173
reviewed
Apr 25, 2018
|
|
||
| for(var extensionID of extensionList) { | ||
| var siteExtensionDetails = null; | ||
|
|
||
| // Python extensions are moved to Nuget and the extensions IDs are changed. The belo check ensures that old extensions are mapped to new extension ID. | ||
| if(!allSiteExtensionMap[extensionID]){ |
| @@ -129,6 +129,26 @@ export class KuduTests { | |||
| } | |||
| } | |||
|
|
|||
| public static async getAllSiteExtensions() { | |||
| var extensionLocalPaths: string = ""; | ||
| for(var siteExtension of siteExtensions) { | ||
| siteExtensionMap[siteExtension.id] = siteExtension; | ||
| } | ||
| for(var siteExtension of allSiteExtensions) { | ||
| allSiteExtensionMap[siteExtension.id] = siteExtension; |
There was a problem hiding this comment.
suggestion: Can we include the title too in the map?
vincent1173
reviewed
Apr 26, 2018
| @@ -141,6 +141,7 @@ | |||
| "loc.messages.FailedToStartContinuousWebJob": "Failed to start continuous WebJob '%s'. Error: %s", | |||
| "loc.messages.FailedToStopContinuousWebJob": "Failed to stop continuous WebJob '%s'. Error: %s", | |||
| "loc.messages.FailedToGetSiteExtensions": "Failed to get site extensions. Error: %s", | |||
| "loc.messages.FailedToGetAllSiteExtensions": "Failed to get all site extensions. Error: %s", | |||
There was a problem hiding this comment.
nit: Failed to get extension feed
vincent1173
reviewed
Apr 26, 2018
|
|
||
| for(var extensionID of extensionList) { | ||
| var siteExtensionDetails = null; | ||
|
|
||
| // Python extensions are moved to Nuget and the extensions IDs are changed. The belo check ensures that old extensions are mapped to new extension ID. | ||
| if(allSiteExtensionMap[extensionID] && allSiteExtensionMap[extensionID].title == extensionID) { |
There was a problem hiding this comment.
Can we simplify the condition?
There was a problem hiding this comment.
we are updating extensionID only when its value is matching title of some siteextension.
vincent1173
approved these changes
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic install extensions drop down
Issue to remove escape character in extension title:
toby-meyer/AzSecurityPackRedirectAndHeadersMed#4