improving success criteria for war package deployment . #7063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachinma
approved these changes
Apr 24, 2018
vincent1173
reviewed
Apr 24, 2018
| @@ -10,6 +10,7 @@ var msDeploy = require('webdeployment-common/deployusingmsdeploy.js'); | |||
|
|
|||
| export async function DeployWar(webPackage, taskParams: TaskParameters, msDeployPublishingProfile, kuduService: Kudu, appServiceUtility: AzureAppServiceUtility): Promise<void> { | |||
| // get list of files before deploying to the web app. | |||
| await appServiceUtility.pingApplication(); | |||
There was a problem hiding this comment.
why ping required here?
There was a problem hiding this comment.
We observed minor difference in "MTime" of the "root" folder just after we first ping or fetch the file directory, to counter this we are pinging the application once before fetching the file directory.
The intention is to reduce the number of cases where there is a minor change in the modified time.
hiyadav
added a commit
that referenced
this pull request
Apr 24, 2018
hiyadav
added a commit
that referenced
this pull request
Apr 25, 2018
hiyadav
added a commit
that referenced
this pull request
May 2, 2018
hiyadav
added a commit
that referenced
this pull request
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.