[Utility] Added option to select 7z level of compression. #7058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alexwiese
changed the title
alexwiese
force-pushed
the
7z-compression-level
branch
4 times, most recently
from
5bcd0bd to
5f63ebe
Compare
|
@alexwiese thanks for this great contribution! Nice work. Two thoughts:
- task: ArchiveFiles@2
inputs:
rootFolderOrFile: '$(system.defaultWorkingDirectory)'
archiveType: 7z
sevenZipCompression: maximumInstead of: - task: ArchiveFiles@2
inputs:
rootFolderOrFile: '$(system.defaultWorkingDirectory)'
archiveType: 7z
sevenZipCompression: 7 |
brcrista
reviewed
Apr 30, 2018
Tasks/ArchiveFiles/archivefiles.ts
Outdated
| @@ -79,6 +79,12 @@ function sevenZipArchive(archive: string, compression: string, files: string[]) | |||
| var sevenZip = tl.createToolRunner(getSevenZipLocation()); | |||
| sevenZip.arg('a'); | |||
| sevenZip.arg('-t' + compression); | |||
|
|
|||
| const sevenZipCompression = tl.getInput('sevenZipCompression', false); | |||
| if(sevenZipCompression) { | |||
brcrista
approved these changes
Apr 30, 2018
|
Looks good to me, but I don't own this task. I'll let @bryanmacfarlane or @ericsciple complete the merge if they agree with adding this parameter. |
alexwiese
force-pushed
the
7z-compression-level
branch
from
5f63ebe to
b259644
Compare
|
@davidstaheli @brcrista thanks. Makes sense. Please see latest commit. |
|
For safety with values people type in YAML, you could call toLower() on sevenZipCompression before switching on it. |
alexwiese
force-pushed
the
7z-compression-level
branch
from
b259644 to
3915de1
Compare
|
This should be ready to merge now. |
alexwiese
force-pushed
the
7z-compression-level
branch
2 times, most recently
from
f995f0b to
7979b90
Compare
alexwiese
force-pushed
the
7z-compression-level
branch
3 times, most recently
from
6366e41 to
6331c24
Compare
|
@alexwiese sorry this slipped through the cracks! If you're still interested, I think we should take this. If you can resolve conflicts and update the task.json/task.loc.json to 2.159.0 I'll merge. |
alexwiese
force-pushed
the
7z-compression-level
branch
from
6331c24 to
19b6f21
Compare
|
@damccorm done :) |
|
Merged! Thanks for the really quick turnaround 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to the
tarCompressionoption, this change allows the user to select the level of compression for 7z files.The option names follow the naming conventions used by 7z.