Python extension path fix - Azure App Service Manage Task #7044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent1173
added
Area: Release
Area: AzureAppService
vincent1173
requested review from
KrishnaAdityaB,
Ajay-MS,
sachinma and
dikhakha
dikhakha
reviewed
Apr 23, 2018
| @@ -128,7 +129,7 @@ export class KuduServiceUtils { | |||
| } | |||
|
|
|||
| private _getExtensionLocalPath(extensionInfo: JSON): string { | |||
| var extensionId: string = extensionInfo['id']; | |||
| var extensionId: string = extensionInfo['id'].replace(pythonExtensionPrefix, ""); | |||
There was a problem hiding this comment.
do you want to do this only for python ?
There was a problem hiding this comment.
yes, planned to do only for Python. but the check wont harm other extensions, as they dont have this prefix as of now. will be removing this once dynamic extension feature is available. //adding comment to ensure the same.
KrishnaAdityaB
approved these changes
Apr 23, 2018
| @@ -53,8 +54,8 @@ export class KuduServiceUtils { | |||
|
|
|||
| for(var extensionID of extensionList) { | |||
| var siteExtensionDetails = null; | |||
| if(siteExtensionMap[extensionID]) { | |||
| siteExtensionDetails = siteExtensionMap[extensionID]; | |||
| if(siteExtensionMap[extensionID] || (extensionID.startsWith('python') && siteExtensionMap[pythonExtensionPrefix + extensionID])) { | |||
There was a problem hiding this comment.
Should we do case insensitive check?
The same applies for replace call below
There was a problem hiding this comment.
case insensitive check is not required here, as it worked for early scenarios.
However, When extension is made dynamic list, it will be handled.
| @@ -53,8 +54,8 @@ export class KuduServiceUtils { | |||
|
|
|||
| for(var extensionID of extensionList) { | |||
| var siteExtensionDetails = null; | |||
| if(siteExtensionMap[extensionID]) { | |||
| siteExtensionDetails = siteExtensionMap[extensionID]; | |||
| if(siteExtensionMap[extensionID] || (extensionID.startsWith('python') && siteExtensionMap[pythonExtensionPrefix + extensionID])) { | |||
There was a problem hiding this comment.
Add some comment on why we are doing this
dikhakha
approved these changes
Apr 23, 2018
sachinma
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.