Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users/rok/msi node based task #6981

Merged
merged 25 commits into from
Apr 15, 2018
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
4110144
MSI node changes
RoshanKumarMicrosoft Mar 9, 2018
691133f
msi changes argument pass
RoshanKumarMicrosoft Mar 9, 2018
074bd58
review incoporated
RoshanKumarMicrosoft Mar 19, 2018
9d632b2
aftet review incorprated
RoshanKumarMicrosoft Apr 13, 2018
c0456bd
After camelcase for enum name
RoshanKumarMicrosoft Mar 29, 2018
2e0243e
proper identation
RoshanKumarMicrosoft Apr 2, 2018
803e015
L0 modifieed
RoshanKumarMicrosoft Apr 2, 2018
1a8d636
build failure
RoshanKumarMicrosoft Apr 2, 2018
459489d
error messgae changed
RoshanKumarMicrosoft Apr 4, 2018
5652ec1
Url changed
RoshanKumarMicrosoft Apr 12, 2018
f7deaaa
test case changes
RoshanKumarMicrosoft Apr 12, 2018
2737d3d
after copying in mysql
RoshanKumarMicrosoft Apr 12, 2018
783ba99
removing quotes
RoshanKumarMicrosoft Apr 12, 2018
8ac52e6
azure app service manage task resource copy
RoshanKumarMicrosoft Apr 12, 2018
c32de1a
key vault conflict
RoshanKumarMicrosoft Apr 12, 2018
299f2ba
azure RG task
RoshanKumarMicrosoft Apr 12, 2018
cd273d6
resolving conflit with azurerm
RoshanKumarMicrosoft Apr 12, 2018
338bb66
javatool installer
RoshanKumarMicrosoft Apr 12, 2018
8001ae6
jenkins download artifact
RoshanKumarMicrosoft Apr 13, 2018
9ea1628
packerbuild
RoshanKumarMicrosoft Apr 13, 2018
fa9434b
status code changed
RoshanKumarMicrosoft Apr 12, 2018
7bceea4
till updated task version
RoshanKumarMicrosoft Apr 12, 2018
ab1727d
review incorporated
RoshanKumarMicrosoft Apr 12, 2018
aad7e3c
review incorporated
RoshanKumarMicrosoft Apr 12, 2018
0953425
revwerting package json changes
RoshanKumarMicrosoft Apr 15, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
"loc.messages.RestartAppServiceAccepted": "Restart request accepted by App Service : %s",
"loc.messages.InvalidAction": "Invalid Action selected !",
"loc.messages.WARNINGCannotupdatedeploymentstatusSCMendpointisnotenabledforthiswebsite": "WARNING: Cannot update deployment status. SCM endpoint is not enabled for this website.",
"loc.messages.CouldnotfetchaccesstokenforAzureStatusCode": "Could not fetch acccess token for Azure App Service. StatusCode %s (%s)",
"loc.messages.WebAppDoesntExist": "Web app '%s' doesn't exist.",
"loc.messages.UnabletoretrieveWebAppID": "Unable to retrieve connection details for Azure App Service:'%s'. Status Code: %s",
"loc.messages.StartingSwapSlot": "Requesting swap slot for Web App : %s",
Expand All @@ -78,7 +77,6 @@
"loc.messages.UnableToFetchContinuousWebJobs": "Unable to fetch continuous web jobs",
"loc.messages.UnableToStartContinuousWebJob": "Unable to start continuous web job",
"loc.messages.UnableToStopContinuousWebJob": "Unable to stop continuous web job",
"loc.messages.CouldNotFetchAccessTokenforAzureStatusCode": "Could not fetch access token for azure. Status code: %s, status message: %s",
"loc.messages.AppNameCannotBeNull": "App name cannot be null or undefined and it must be of type string.",
"loc.messages.SlotNameCannotBeNull": "Slot name cannot be null or undefined and it must be of type string.",
"loc.messages.SourceSlotNameCannotBeNull": "Source slot name cannot be null or undefined and it must be of type string.",
Expand Down Expand Up @@ -164,5 +162,8 @@
"loc.messages.WebJobAlreadyInStoppedState": "WebJob '%s' is already in stopped state.",
"loc.messages.RestartingKuduService": "Restarting Kudu Service.",
"loc.messages.RestartedKuduService": "Kudu Service restarted.",
"loc.messages.FailedToRestartKuduService": "Failed to restart kudu Service. %s."
"loc.messages.FailedToRestartKuduService": "Failed to restart kudu Service. %s.",
"loc.messages.CouldNotFetchAccessTokenforAzureStatusCode": "Could not fetch access token for Azure. Status code: %s, status message: %s",
"loc.messages.CouldNotFetchAccessTokenforMSIDueToMSINotConfiguredProperlyStatusCode": "Could not fetch access token for Managed Service Principal. Please configure Managed Service Identity (MSI) for virtual machine 'https://aka.ms/azure-msi-docs'. Status code: %s, status message: %s",
"loc.messages.CouldNotFetchAccessTokenforMSIStatusCode": "Could not fetch access token for Managed Service Principal. Status code: %s, status message: %s"
}
9 changes: 5 additions & 4 deletions Tasks/AzureAppServiceManage/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"version": {
"Major": 0,
"Minor": 2,
"Patch": 26
"Patch": 27
},
"minimumAgentVersion": "1.102.0",
"instanceNameFormat": "$(Action): $(WebAppName)",
Expand Down Expand Up @@ -288,7 +288,6 @@
"RestartAppServiceAccepted": "Restart request accepted by App Service : %s",
"InvalidAction": "Invalid Action selected !",
"WARNINGCannotupdatedeploymentstatusSCMendpointisnotenabledforthiswebsite": "WARNING: Cannot update deployment status. SCM endpoint is not enabled for this website.",
"CouldnotfetchaccesstokenforAzureStatusCode": "Could not fetch acccess token for Azure App Service. StatusCode %s (%s)",
"WebAppDoesntExist": "Web app '%s' doesn't exist.",
"UnabletoretrieveWebAppID": "Unable to retrieve connection details for Azure App Service:'%s'. Status Code: %s",
"StartingSwapSlot": "Requesting swap slot for Web App : %s",
Expand All @@ -313,7 +312,6 @@
"UnableToFetchContinuousWebJobs": "Unable to fetch continuous web jobs",
"UnableToStartContinuousWebJob": "Unable to start continuous web job",
"UnableToStopContinuousWebJob": "Unable to stop continuous web job",
"CouldNotFetchAccessTokenforAzureStatusCode": "Could not fetch access token for azure. Status code: %s, status message: %s",
"AppNameCannotBeNull": "App name cannot be null or undefined and it must be of type string.",
"SlotNameCannotBeNull": "Slot name cannot be null or undefined and it must be of type string.",
"SourceSlotNameCannotBeNull": "Source slot name cannot be null or undefined and it must be of type string.",
Expand Down Expand Up @@ -399,6 +397,9 @@
"WebJobAlreadyInStoppedState": "WebJob '%s' is already in stopped state.",
"RestartingKuduService": "Restarting Kudu Service.",
"RestartedKuduService": "Kudu Service restarted.",
"FailedToRestartKuduService": "Failed to restart kudu Service. %s."
"FailedToRestartKuduService": "Failed to restart kudu Service. %s.",
"CouldNotFetchAccessTokenforAzureStatusCode": "Could not fetch access token for Azure. Status code: %s, status message: %s",
"CouldNotFetchAccessTokenforMSIDueToMSINotConfiguredProperlyStatusCode": "Could not fetch access token for Managed Service Principal. Please configure Managed Service Identity (MSI) for virtual machine 'https://aka.ms/azure-msi-docs'. Status code: %s, status message: %s",
"CouldNotFetchAccessTokenforMSIStatusCode": "Could not fetch access token for Managed Service Principal. Status code: %s, status message: %s"
}
}
9 changes: 5 additions & 4 deletions Tasks/AzureAppServiceManage/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"version": {
"Major": 0,
"Minor": 2,
"Patch": 26
"Patch": 27
},
"minimumAgentVersion": "1.102.0",
"instanceNameFormat": "ms-resource:loc.instanceNameFormat",
Expand Down Expand Up @@ -292,7 +292,6 @@
"RestartAppServiceAccepted": "ms-resource:loc.messages.RestartAppServiceAccepted",
"InvalidAction": "ms-resource:loc.messages.InvalidAction",
"WARNINGCannotupdatedeploymentstatusSCMendpointisnotenabledforthiswebsite": "ms-resource:loc.messages.WARNINGCannotupdatedeploymentstatusSCMendpointisnotenabledforthiswebsite",
"CouldnotfetchaccesstokenforAzureStatusCode": "ms-resource:loc.messages.CouldnotfetchaccesstokenforAzureStatusCode",
"WebAppDoesntExist": "ms-resource:loc.messages.WebAppDoesntExist",
"UnabletoretrieveWebAppID": "ms-resource:loc.messages.UnabletoretrieveWebAppID",
"StartingSwapSlot": "ms-resource:loc.messages.StartingSwapSlot",
Expand All @@ -317,7 +316,6 @@
"UnableToFetchContinuousWebJobs": "ms-resource:loc.messages.UnableToFetchContinuousWebJobs",
"UnableToStartContinuousWebJob": "ms-resource:loc.messages.UnableToStartContinuousWebJob",
"UnableToStopContinuousWebJob": "ms-resource:loc.messages.UnableToStopContinuousWebJob",
"CouldNotFetchAccessTokenforAzureStatusCode": "ms-resource:loc.messages.CouldNotFetchAccessTokenforAzureStatusCode",
"AppNameCannotBeNull": "ms-resource:loc.messages.AppNameCannotBeNull",
"SlotNameCannotBeNull": "ms-resource:loc.messages.SlotNameCannotBeNull",
"SourceSlotNameCannotBeNull": "ms-resource:loc.messages.SourceSlotNameCannotBeNull",
Expand Down Expand Up @@ -403,6 +401,9 @@
"WebJobAlreadyInStoppedState": "ms-resource:loc.messages.WebJobAlreadyInStoppedState",
"RestartingKuduService": "ms-resource:loc.messages.RestartingKuduService",
"RestartedKuduService": "ms-resource:loc.messages.RestartedKuduService",
"FailedToRestartKuduService": "ms-resource:loc.messages.FailedToRestartKuduService"
"FailedToRestartKuduService": "ms-resource:loc.messages.FailedToRestartKuduService",
"CouldNotFetchAccessTokenforAzureStatusCode": "ms-resource:loc.messages.CouldNotFetchAccessTokenforAzureStatusCode",
"CouldNotFetchAccessTokenforMSIDueToMSINotConfiguredProperlyStatusCode": "ms-resource:loc.messages.CouldNotFetchAccessTokenforMSIDueToMSINotConfiguredProperlyStatusCode",
"CouldNotFetchAccessTokenforMSIStatusCode": "ms-resource:loc.messages.CouldNotFetchAccessTokenforMSIStatusCode"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"loc.messages.SecretCannotBeEmpty": "secret must be a non empty string.",
"loc.messages.armUrlCannotBeEmpty": "arm Url must be a non empty string.",
"loc.messages.authorityUrlCannotBeEmpty": "authority must be a non empty string.",
"loc.messages.CouldNotFetchAccessTokenforAzureStatusCode": "Could not fetch access token for azure. Status code: %s, status message: %s",
"loc.messages.CallbackCannotBeNull": "callback cannot be null.",
"loc.messages.CredentialsCannotBeNull": "'credentials' cannot be null.",
"loc.messages.SubscriptionIdCannotBeNull": "'subscriptionId' cannot be null.",
Expand All @@ -40,5 +39,8 @@
"loc.messages.GetSecretFailedBecauseOfInvalidCharacters": "Cannot find the secret with name: %s. Secret name must be a string 1-127 characters in length containing only 0-9, a-z, A-Z, and -",
"loc.messages.UploadingAttachment": "Uploading %s as attachment",
"loc.messages.CouldNotWriteToFile": "Could not save content to file. Failed with an error %s",
"loc.messages.CouldNotMaskSecret": "%s value has regular expressions hence could not mask completely"
"loc.messages.CouldNotMaskSecret": "%s value has regular expressions hence could not mask completely",
"loc.messages.CouldNotFetchAccessTokenforAzureStatusCode": "Could not fetch access token for Azure. Status code: %s, status message: %s",
"loc.messages.CouldNotFetchAccessTokenforMSIDueToMSINotConfiguredProperlyStatusCode": "Could not fetch access token for Managed Service Principal. Please configure Managed Service Identity (MSI) for virtual machine 'https://aka.ms/azure-msi-docs'. Status code: %s, status message: %s",
"loc.messages.CouldNotFetchAccessTokenforMSIStatusCode": "Could not fetch access token for Managed Service Principal. Status code: %s, status message: %s"
}
20 changes: 17 additions & 3 deletions Tasks/AzureKeyVault/npm-shrinkwrap.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions Tasks/AzureKeyVault/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"version": {
"Major": 1,
"Minor": 0,
"Patch": 16
"Patch": 17
},
"demands": [],
"minimumAgentVersion": "2.0.0",
Expand Down Expand Up @@ -70,7 +70,6 @@
"SecretCannotBeEmpty": "secret must be a non empty string.",
"armUrlCannotBeEmpty": "arm Url must be a non empty string.",
"authorityUrlCannotBeEmpty": "authority must be a non empty string.",
"CouldNotFetchAccessTokenforAzureStatusCode": "Could not fetch access token for azure. Status code: %s, status message: %s",
"CallbackCannotBeNull": "callback cannot be null.",
"CredentialsCannotBeNull": "'credentials' cannot be null.",
"SubscriptionIdCannotBeNull": "'subscriptionId' cannot be null.",
Expand All @@ -95,6 +94,9 @@
"GetSecretFailedBecauseOfInvalidCharacters": "Cannot find the secret with name: %s. Secret name must be a string 1-127 characters in length containing only 0-9, a-z, A-Z, and -",
"UploadingAttachment": "Uploading %s as attachment",
"CouldNotWriteToFile": "Could not save content to file. Failed with an error %s",
"CouldNotMaskSecret": "%s value has regular expressions hence could not mask completely"
"CouldNotMaskSecret": "%s value has regular expressions hence could not mask completely",
"CouldNotFetchAccessTokenforAzureStatusCode": "Could not fetch access token for Azure. Status code: %s, status message: %s",
"CouldNotFetchAccessTokenforMSIDueToMSINotConfiguredProperlyStatusCode": "Could not fetch access token for Managed Service Principal. Please configure Managed Service Identity (MSI) for virtual machine 'https://aka.ms/azure-msi-docs'. Status code: %s, status message: %s",
"CouldNotFetchAccessTokenforMSIStatusCode": "Could not fetch access token for Managed Service Principal. Status code: %s, status message: %s"
}
}
8 changes: 5 additions & 3 deletions Tasks/AzureKeyVault/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"version": {
"Major": 1,
"Minor": 0,
"Patch": 16
"Patch": 17
},
"demands": [],
"minimumAgentVersion": "2.0.0",
Expand Down Expand Up @@ -72,7 +72,6 @@
"SecretCannotBeEmpty": "ms-resource:loc.messages.SecretCannotBeEmpty",
"armUrlCannotBeEmpty": "ms-resource:loc.messages.armUrlCannotBeEmpty",
"authorityUrlCannotBeEmpty": "ms-resource:loc.messages.authorityUrlCannotBeEmpty",
"CouldNotFetchAccessTokenforAzureStatusCode": "ms-resource:loc.messages.CouldNotFetchAccessTokenforAzureStatusCode",
"CallbackCannotBeNull": "ms-resource:loc.messages.CallbackCannotBeNull",
"CredentialsCannotBeNull": "ms-resource:loc.messages.CredentialsCannotBeNull",
"SubscriptionIdCannotBeNull": "ms-resource:loc.messages.SubscriptionIdCannotBeNull",
Expand All @@ -97,6 +96,9 @@
"GetSecretFailedBecauseOfInvalidCharacters": "ms-resource:loc.messages.GetSecretFailedBecauseOfInvalidCharacters",
"UploadingAttachment": "ms-resource:loc.messages.UploadingAttachment",
"CouldNotWriteToFile": "ms-resource:loc.messages.CouldNotWriteToFile",
"CouldNotMaskSecret": "ms-resource:loc.messages.CouldNotMaskSecret"
"CouldNotMaskSecret": "ms-resource:loc.messages.CouldNotMaskSecret",
"CouldNotFetchAccessTokenforAzureStatusCode": "ms-resource:loc.messages.CouldNotFetchAccessTokenforAzureStatusCode",
"CouldNotFetchAccessTokenforMSIDueToMSINotConfiguredProperlyStatusCode": "ms-resource:loc.messages.CouldNotFetchAccessTokenforMSIDueToMSINotConfiguredProperlyStatusCode",
"CouldNotFetchAccessTokenforMSIStatusCode": "ms-resource:loc.messages.CouldNotFetchAccessTokenforMSIStatusCode"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,8 @@
"loc.messages.CallbackCannotBeNull": "callback cannot be null.",
"loc.messages.UnableToCreateDatabaseException": "Unable to create database.",
"loc.messages.WindowMysqlClientMissingError": "Mysql Client is missing in window agent box. Please install it by running mysql client installer 'https://aka.ms/window-mysqlcli-installer' script file in your agent box.",
"loc.messages.LinuxMysqlClientMissingError": "Mysql Client is missing in linux agent box. Please install it by running 'apt-get install mysql-client'."
"loc.messages.LinuxMysqlClientMissingError": "Mysql Client is missing in linux agent box. Please install it by running 'apt-get install mysql-client'.",
"loc.messages.CouldNotFetchAccessTokenforAzureStatusCode": "Could not fetch access token for Azure. Status code: %s, status message: %s",
"loc.messages.CouldNotFetchAccessTokenforMSIDueToMSINotConfiguredProperlyStatusCode": "Could not fetch access token for Managed Service Principal. Please configure Managed Service Identity (MSI) for virtual machine 'https://aka.ms/azure-msi-docs'. Status code: %s, status message: %s",
"loc.messages.CouldNotFetchAccessTokenforMSIStatusCode": "Could not fetch access token for Managed Service Principal. Status code: %s, status message: %s"
}
7 changes: 5 additions & 2 deletions Tasks/AzureMysqlDeployment/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"version": {
"Major": 1,
"Minor": 0,
"Patch": 0
"Patch": 1
},
"demands": [],
"minimumAgentVersion": "1.100.0",
Expand Down Expand Up @@ -218,6 +218,9 @@
"CallbackCannotBeNull": "callback cannot be null.",
"UnableToCreateDatabaseException": "Unable to create database.",
"WindowMysqlClientMissingError": "Mysql Client is missing in window agent box. Please install it by running mysql client installer 'https://aka.ms/window-mysqlcli-installer' script file in your agent box.",
"LinuxMysqlClientMissingError": "Mysql Client is missing in linux agent box. Please install it by running 'apt-get install mysql-client'."
"LinuxMysqlClientMissingError": "Mysql Client is missing in linux agent box. Please install it by running 'apt-get install mysql-client'.",
"CouldNotFetchAccessTokenforAzureStatusCode": "Could not fetch access token for Azure. Status code: %s, status message: %s",
"CouldNotFetchAccessTokenforMSIDueToMSINotConfiguredProperlyStatusCode": "Could not fetch access token for Managed Service Principal. Please configure Managed Service Identity (MSI) for virtual machine 'https://aka.ms/azure-msi-docs'. Status code: %s, status message: %s",
"CouldNotFetchAccessTokenforMSIStatusCode": "Could not fetch access token for Managed Service Principal. Status code: %s, status message: %s"
}
}
7 changes: 5 additions & 2 deletions Tasks/AzureMysqlDeployment/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"version": {
"Major": 1,
"Minor": 0,
"Patch": 0
"Patch": 1
},
"demands": [],
"minimumAgentVersion": "1.100.0",
Expand Down Expand Up @@ -220,6 +220,9 @@
"CallbackCannotBeNull": "ms-resource:loc.messages.CallbackCannotBeNull",
"UnableToCreateDatabaseException": "ms-resource:loc.messages.UnableToCreateDatabaseException",
"WindowMysqlClientMissingError": "ms-resource:loc.messages.WindowMysqlClientMissingError",
"LinuxMysqlClientMissingError": "ms-resource:loc.messages.LinuxMysqlClientMissingError"
"LinuxMysqlClientMissingError": "ms-resource:loc.messages.LinuxMysqlClientMissingError",
"CouldNotFetchAccessTokenforAzureStatusCode": "ms-resource:loc.messages.CouldNotFetchAccessTokenforAzureStatusCode",
"CouldNotFetchAccessTokenforMSIDueToMSINotConfiguredProperlyStatusCode": "ms-resource:loc.messages.CouldNotFetchAccessTokenforMSIDueToMSINotConfiguredProperlyStatusCode",
"CouldNotFetchAccessTokenforMSIStatusCode": "ms-resource:loc.messages.CouldNotFetchAccessTokenforMSIStatusCode"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@
"loc.messages.SecretCannotBeEmpty": "secret must be a non empty string.",
"loc.messages.armUrlCannotBeEmpty": "arm Url must be a non empty string.",
"loc.messages.authorityUrlCannotBeEmpty": "authority must be a non empty string.",
"loc.messages.CouldNotFetchAccessTokenforAzureStatusCode": "Could not fetch access token for azure. Status code: %s, status message: %s",
"loc.messages.LoadBalancerNameCannotBeNull": "'loadBalancerName cannot be null or undefined and it must be of type string.'",
"loc.messages.NetworkInterfaceNameCannotBeNull": "networkInterfaceName cannot be null or undefined and it must be of type string.",
"loc.messages.NetworkSecurityGroupNameCannotBeNull": "networkSecurityGroupName cannot be null or undefined and it must be of type string.",
Expand Down Expand Up @@ -169,5 +168,8 @@
"loc.messages.UnableToFetchActiveDirectory": "Unable to fetch active directory resource id.",
"loc.messages.SpecifiedAzureRmEndpointIsInvalid": "Specified AzureRm endpoint url : '{0}' is invalid.",
"loc.messages.FailedToFetchAzureStackDependencyData": "Failed to fetch azure stack dependency data, error message : {0}",
"loc.messages.UnableToReadResponseBody": "Unable to read response body. Error: %s"
"loc.messages.UnableToReadResponseBody": "Unable to read response body. Error: %s",
"loc.messages.CouldNotFetchAccessTokenforAzureStatusCode": "Could not fetch access token for Azure. Status code: %s, status message: %s",
"loc.messages.CouldNotFetchAccessTokenforMSIDueToMSINotConfiguredProperlyStatusCode": "Could not fetch access token for Managed Service Principal. Please configure Managed Service Identity (MSI) for virtual machine 'https://aka.ms/azure-msi-docs'. Status code: %s, status message: %s",
"loc.messages.CouldNotFetchAccessTokenforMSIStatusCode": "Could not fetch access token for Managed Service Principal. Status code: %s, status message: %s"
}
Loading