Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML Var. substitution - Escape XML characters #6980

Merged
merged 4 commits into from
Apr 20, 2018
Merged

XML Var. substitution - Escape XML characters #6980

merged 4 commits into from
Apr 20, 2018

Conversation

vincent1173
Copy link
Contributor

@vincent1173 vincent1173 commented Apr 13, 2018 •
edited
Loading

@vincent1173 vincent1173 reopened this Apr 18, 2018
@vincent1173 vincent1173 changed the title xml poc XML Var. substitution - Escape XML characters Apr 18, 2018
@vincent1173 vincent1173 added Area: Release Area: AzureAppService Label to monitor Azure App Service issues labels Apr 18, 2018
Ajay-MS
Ajay-MS reviewed Apr 20, 2018
View reviewed changes
Tasks/Common/webdeployment-common/xmlvariablesubstitutionutility.ts Outdated
@@ -262,4 +265,18 @@ function updateXmlConnectionStringsNodeAttribute(xmlDomNode, variableMap, replac
}

return isSubstitutionApplied;
}

function replaceEscapeXMLCharacters(xmlDOM) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename xmlDOM to xmlDomNode in method argument?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed.

Ajay-MS
Ajay-MS reviewed Apr 20, 2018
View reviewed changes
Tasks/Common/webdeployment-common/xmlvariablesubstitutionutility.ts Outdated
return;
}

for(var xmlAttributes in xmlDOM.attrs) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xmlAttributes should be singular.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. thanks.

@vincent1173 vincent1173 merged commit 7bee928 into master Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ajay-MS Ajay-MS Ajay-MS approved these changes

@kmkumaran kmkumaran Awaiting requested review from kmkumaran

Assignees

@kmkumaran kmkumaran

Labels
Area: AzureAppService Label to monitor Azure App Service issues Area: Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincent1173 @Ajay-MS @kmkumaran