Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileshare partial download fix (#6944) #6961

Merged
merged 2 commits into from
Apr 12, 2018
Merged

fileshare partial download fix (#6944) #6961

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
150f19b
fileshare partial download fix (#6944)
omeshp Apr 12, 2018
88d20bc
update version
omeshp Apr 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Tasks/DownloadBuildArtifacts/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,8 @@ async function main(): Promise<void> {
}

console.log(tl.loc("DownloadArtifacts", artifactLocation));
var fileShareProvider = new providers.FilesystemProvider(artifactLocation);
var fileSystemProvider = new providers.FilesystemProvider(downloadPath + '\\' + artifact.name);
var fileShareProvider = new providers.FilesystemProvider(artifactLocation, artifact.name);
var fileSystemProvider = new providers.FilesystemProvider(downloadPath);

downloadPromises.push(downloader.processItems(fileShareProvider, fileSystemProvider, downloaderOptions).catch((reason) => {
reject(reason);
Expand Down
6 changes: 3 additions & 3 deletions Tasks/DownloadBuildArtifacts/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Tasks/DownloadBuildArtifacts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
"dependencies": {
"vsts-task-lib": "2.1.0",
"vso-node-api": "^6.2.8-preview",
"artifact-engine": "0.1.19"
"artifact-engine": "0.1.21"
}
}
4 changes: 2 additions & 2 deletions Tasks/DownloadBuildArtifacts/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 0,
"Minor": 133,
"Patch": 1
"Minor": 134,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be 133 & patch 2?

"Patch": 0
},
"groups": [
{
Expand Down
4 changes: 2 additions & 2 deletions Tasks/DownloadBuildArtifacts/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 0,
"Minor": 133,
"Patch": 1
"Minor": 134,
"Patch": 0
},
"groups": [
{
Expand Down